test(opy): consolidate compatibility test metadata - #338
Conversation
Teakowa
left a comment
There was a problem hiding this comment.
-
tools/overpy/run_oracle.py:96still requires anattributionobject withkind/origin/license/redistributablefor every fixture, and the synthetic manifests keep that boilerplate. #337 explicitly limits source attribution/licensing metadata to cases with a concrete third-party/redistribution/reproducibility need; this preserves the generic metadata schema under a new name. Make attribution optional and validate it only where the fixture actually needs it, then remove the WrightKit-authored synthetic attribution records. -
The ADR cleanup AC is still incomplete. Accepted/current material still uses the generic concepts being removed:
docs/adr/0003-first-party-provider-boundary.md:19saysdiagnostics/provenance,docs/adr/0005-opy-canonical-program-lowering.md:25refers to a publicprovenance contract, anddocs/adr/README.md:54saysimplementation evidence. Replace these with the concrete concern (source mapping/source identity/tests/current implementation reality as applicable). Historical wording inside superseded ADR-0002 can remain.
Summary
Verification
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-features -- -D warningscargo test --workspace --all-targets --all-featurespython3 -m unittest discover -s tools/overpy/tests(28 passed)tests.sourcefrom one fixture fails manifest loadingOracle snapshot validation matched reference behavior and outputs. Two pre-existing snapshots differ only in transient pnpm install stdout ordering on this host; snapshots were not rewritten.
Fixes #337