feat(compiler): escape filtered words in rule names and settings strings - #376
Merged
Merged
Conversation
Apply the pinned OverPy rule-name word filter in its own order, not only for rigger and admin, and pin it with an oracle-backed structural fixture. Refs #366
Apply the shared filtered-word escape to main.modeName and main.description as the pinned OverPy does, pin it with an oracle-backed settings fixture, and mark the filtered-word row supported. Fixes #374
Teakowa
requested changes
Sep 25, 2026
Use the reference \s set (no U+0085) for the spaced rigger match and pin every whole-word entry negatively, the spaced r i gger positive case, and U+0085 with the oracle. Refs #374
Teakowa
approved these changes
Sep 25, 2026
This was referenced Sep 25, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #374
Implements the approved filtered-word escaping (ADR-0007, #375).
r i gg e rcase.main.modeNameandmain.description(escape first, filter second).structural-rule-name-words; add oracle-backedstructural-settings-words(quotes, backslash, zero-width character, whole-word negative).tooling-and-backend.mdfiltered-word row is now supported.Verification: fmt, clippy
-D warnings, workspace tests,tools/overpy/tests, andrun_native.py(known-gap unchanged at 8; both new fixtures match).