fix(compiler): spell startForcingThrottle limits 0 and 1 as False and True under optimizeForSize - #382
Merged
Conversation
… True under optimizeForSize Pinned OverPy 9.7.10 marks the six throttle limits canReplace0ByFalse and canReplace1ByTrue, so #!optimizeForSize writes them as False and True. Bastion's startForcingThrottle(0, 0, 0, 0, 0, 0) compiled to numeric zeros, the last remaining difference from OverPy on its production entries.
This was referenced Sep 25, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under
#!optimizeForSizepinned OverPy 9.7.10 writes the sixstartForcingThrottlelimits (canReplace0ByFalse/canReplace1ByTrue) asFalse/True. opy-rs left them numeric, so Bastion'sstartForcingThrottle(0, 0, 0, 0, 0, 0)differed from OverPy on the productionmain.opy.This follows the existing per-function pattern (
chase_call). The catalog'sparamCoercionsare acceptance flags and are broader than OverPy's replacement flags (for exampleSkip If), so applying them generically changes correct output and breaks the oracle tests. Other OverPycanReplace*parameters remain uncovered; none occur in Bastion's production entries.Verification: fmt, clippy -D warnings, workspace tests pass. Wright 0.2.37 with a provider built from this branch compiles Bastion
main.opy(zh-CN) andexternalMain.opy(en-US); the canonical Wright-vs-OverPy diff is 0 lines for both.