feat(opy): resolve the 53 missing OverPy values - #393
Merged
Merged
Conversation
Add manifest entries and the missing-values oracle probe for the 52 value functions the pinned OverPy 9.7.10 accepts and opy-rs rejected, and lower createWorkshopSettingHero with the other createWorkshopSetting* forms. eventDirection, eventWasEnvironment and eventWasHealthPack resolve as bare event values. Match the reference output for these names: fold literal arguments of the trigonometric, crossProduct, normalize and strLen values, wrap the player, vector, array and team results the reference wraps in First Of in a Boolean slot, and wrap a null Boolean argument of a value nested in any action, not only in an action call. Closes #386
Teakowa
requested changes
Sep 26, 2026
Teakowa
left a comment
Contributor
There was a problem hiding this comment.
One compatibility finding blocks approval.
The pinned OverPy 9.7.10 writes normalize(vectorTowards(a, b)) as Direction Towards(a, b). Add the rewrite and a probe case and regression test for it.
Teakowa
approved these changes
Sep 26, 2026
Teakowa
left a comment
Contributor
There was a problem hiding this comment.
LGTM. The previously reported normalize(vectorTowards(...)) compatibility gap is fixed, covered by a focused regression test and the oracle probe. CI passes on the updated head.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the 53 OverPy values the pinned OverPy 9.7.10 accepts and opy-rs rejected.
missing-valuesoracle probe.createWorkshopSettingHerolowers with the othercreateWorkshopSetting*forms (sort order defaults to0).eventDirection,eventWasEnvironmentandeventWasHealthPackresolve as bare event values.acos/asin/atan2/tan(andDegforms),crossProduct,normalizeandstrLen; theFirst Ofwrap in a Boolean slot for the player/vector/array/team results; and theFirst Ofwrap of a null Boolean argument for a value nested in any action (previously only action calls).getNumberOfHeroeskeepsteamrequired: the reference's defaultTEAMis rejected by the reference itself (Unknown team 'TEAM').Verification
probe_builtins.py, all manifest functions: 4436 probes, 0 unexplained, no newprobe-gaps.jsonentries.validate.py: all 51 probes match the oracle.-D warnings, workspace tests,tools/overpy/tests,run_native.py,structural_gate.py: pass.Notes
createWorkshopSettingBool/Intwith the sort order omitted emit no trailing0, while the reference appends it.Closes #386