Skip to content

Add False/True coercion to the createDummyBot slot parameter #282

Description

@e54-bot

Goal

Let the size-optimized spelling that OverPy writes for the slot of Create Dummy Bot pass canonical validation.

Context

Found by the builtin probe in wrightkit/opy-rs#370 (wrightkit/opy-rs#366). Under #!optimizeForSize the pinned OverPy 9.7.10 writes Create Dummy Bot(Hero(D.Va), All Teams, False, Up, Up) for slot = 0 (and True for 1), per its 0 → false / 1 → true compression (Zezombye/overpy#238). The catalog gives createDummyBot parameter 3 no false_as_number / true_as_number coercion, so validate_canonical_ids rejects False/True there. Every other Number|Boolean slot already carries the coercions.

Scope

  • Add the two coercions to the slot parameter of createDummyBot, after checking that other Number parameters the pinned OverPy compresses in optimizeForSize are not missing them either.

Acceptance criteria

  • Create Dummy Bot(..., False, ...) and True validate and round-trip.
  • The two size:createDummy:arg2=0|1 probes in opy-rs tools/overpy/probe_builtins.py match after the catalog is bumped in opy-rs; catalog-missing-coercion is then removed from probe-gaps.json.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions