Goal
Let the size-optimized spelling that OverPy writes for the slot of Create Dummy Bot pass canonical validation.
Context
Found by the builtin probe in wrightkit/opy-rs#370 (wrightkit/opy-rs#366). Under #!optimizeForSize the pinned OverPy 9.7.10 writes Create Dummy Bot(Hero(D.Va), All Teams, False, Up, Up) for slot = 0 (and True for 1), per its 0 → false / 1 → true compression (Zezombye/overpy#238). The catalog gives createDummyBot parameter 3 no false_as_number / true_as_number coercion, so validate_canonical_ids rejects False/True there. Every other Number|Boolean slot already carries the coercions.
Scope
- Add the two coercions to the slot parameter of
createDummyBot, after checking that other Number parameters the pinned OverPy compresses in optimizeForSize are not missing them either.
Acceptance criteria
Goal
Let the size-optimized spelling that OverPy writes for the slot of
Create Dummy Botpass canonical validation.Context
Found by the builtin probe in wrightkit/opy-rs#370 (wrightkit/opy-rs#366). Under
#!optimizeForSizethe pinned OverPy 9.7.10 writesCreate Dummy Bot(Hero(D.Va), All Teams, False, Up, Up)forslot = 0(andTruefor1), per its0 → false / 1 → truecompression (Zezombye/overpy#238). The catalog givescreateDummyBotparameter 3 nofalse_as_number/true_as_numbercoercion, sovalidate_canonical_idsrejectsFalse/Truethere. Every other Number|Boolean slot already carries the coercions.Scope
createDummyBot, after checking that other Number parameters the pinned OverPy compresses inoptimizeForSizeare not missing them either.Acceptance criteria
Create Dummy Bot(..., False, ...)andTruevalidate and round-trip.size:createDummy:arg2=0|1probes in opy-rstools/overpy/probe_builtins.pymatch after the catalog is bumped in opy-rs;catalog-missing-coercionis then removed fromprobe-gaps.json.