Emit constant wrappers and settings values the way the client accepts them

[e54-bot]

Goal

Text emitted by workshop-rs is accepted by the Workshop client wherever the equivalent OverPy output is: constant wrappers, boolean setting values and action spellings follow the forms the client accepts, in every supported locale.

Context

A production project (OWBastion/Bastion) built through Wright and through pinned OverPy 9.7.10 was imported into the client line by line. The client rejected Wright's zh-CN output at Team(队伍1) and at 队列中的玩家可以加入: 关闭 (OverPy writes 队伍1 and 否). The canonical structural comparison between the two outputs was clean, so it does not detect these. Comparing the two artifacts by vocabulary, call-name counts and the settings block found the classes below. All are reproduced with workshop-rs-cli v0.8.0 alone, by emitting OverPy-shaped input, so the owner is this repository.

Input (OverPy output)	workshop-rs-cli emit, en-US	Note
All Players(Team 1)	All Players(Team(Team 1))	wrapper added; OverPy writes the bare Team constant in a Team-typed slot
Players On Hero(Hero(Mercy), Team 1)	Players On Hero(Mercy, Team(Team 1))	Hero(...) removed in a Hero-typed slot
Array(Hero(D.Va), Hero(Reinhardt), Hero(Winston))	Array(Hero(D.Va), Reinhardt, Winston)	only the first element keeps its wrapper
Custom String("x{0}", Button(Reload))	Custom String("x{0}", Reload)	Button(...) removed in a generic slot
Allow Players Who Are In Queue: No (settings)	Allow Players Who Are In Queue: Off	wrong word for a yes/no setting

• zh-CN. The same input converted to zh-CN gives Team(队伍1): the wrapper name is not localized (the localized name is 队伍, as in the real-project fixtures). The array case is wrapped on every element in this path (数组(英雄(D.Va), 英雄(莱因哈特), 英雄(温斯顿))), so the wrapping rule differs between emit paths.
• Action spellings (zh-CN). Where the catalog lists several spellings, emission picks a different one from OverPy for ten actions: 摧毁所有图标 / 消除所有图标, 摧毁所有世界内文本 / 消除所有地图文本, 摧毁所有效果 / 消除所有效果, 摧毁所有HUD文本 / 消除所有HUD文本, 禁用内置游戏模式播报员 / 关闭游戏预设通告模式, 禁用内置游戏模式完成 / 关闭游戏预设完成条件, 禁用内置游戏模式音乐 / 关闭游戏预设音乐模式, 禁用内置游戏模式计分 / 关闭游戏预设计分模式, 启用内置游戏模式音乐 / 开启游戏预设音乐模式, 继续比赛时间 / 比赛时间继续 (workshop-rs / OverPy). Only the first two of these classes have been confirmed to fail in the client; the rest are unverified there.
• Counts in the project. zh-CN main: 246 Team( wrappers (OverPy has none), 220 按钮( in OverPy against 34 in the Wright output. en-US externalMain: Hero( 135 in OverPy against 9.

Client acceptance of OverPy's forms is established by their production use; acceptance of the other forms is unknown, and the observed failures show at least some are rejected.

Scope

• Decide and document when an enum constant is written with its wrapper (Hero(...), Button(...), Team(...)) and when bare, per slot type, and make every emit path apply it the same way in each locale.
• Localize wrapper names in every locale the catalog declares.
• Emit the client's word for boolean settings that take a yes/no value.
• Where the catalog lists several spellings of an action, choose the emitted one by the evidence classes in ADR-0014, and record the choice.
• Regression coverage: parse then emit of the table's inputs in en-US and zh-CN reproduces them; parse then emit of each OverPy-generated real-project fixture preserves the call-name counts of Team/Hero/Button wrappers and adds no token absent from the input.

Non-goals

• Preserving 0 versus False (done in fix(parser)!: preserve contextual literal substitutions #300).
• Element-count rules.
• What opy-rs writes into the Program (tracked in opy-rs).

Acceptance criteria

• The table above round-trips unchanged in en-US and zh-CN.
• The fixture round-trip check passes in CI.
• A short document states the wrapper rule per slot type with its evidence.

Dependencies

Related: #297, #299, #300, ADR-0014, and wrightkit/opy-rs#388.

[e54-bot]

Re-measured with Wright 0.2.38 (workshop-rs 0.8.0) and opy-provider 0.1.59 on the same project (OWBastion/Bastion at bb33a46), OverPy 9.7.10 as the reference.

Already fixed by the newer versions: False/True counts (1284 / 1283 in zh-CN main, 1197 / 1196 in en-US externalMain), Custom String counts (932 / 932, 585 / 585), and the non-native Set Allowed Heroes. Both production entries compile.

Still open, and all in this issue's scope:

Item	OverPy	Wright
Team( wrapper, zh-CN main / en-US externalMain	0 / 0	246 / 245
Hero( wrapper (zh-CN counts 英雄()	220 / 148	211 / 22
Button( wrapper (zh-CN counts 按钮()	254 / 254	34 / 41
Yes/No setting value	否 / No	关闭 / Off
zh-CN action spellings from the table above	10 spellings	10 different spellings

One more, found in the en-US artifact: a hero constant is written as Jinyu where OverPy writes Hero(Domina) (Array(..., Widowmaker, Jinyu, Sojourn, ...) against Array(..., Hero(Widowmaker), Hero(Domina), Hero(Sojourn), ...)). Where the catalog carries more than one spelling of a hero, emission picks one the client may not accept; this is the same question as the action-spelling choice above.