Skip to content

refactor(catalog)!: narrow public metadata API - #258

Merged
Teakowa merged 3 commits into
mainfrom
codex/workshop-rs-255
Sep 22, 2026
Merged

Teakowa merged 3 commits into
mainfrom
codex/workshop-rs-255

Conversation

@e54-bot

@e54-bot e54-bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • make Catalog storage, schema, and provenance representation private while retaining stable identity and locale queries
  • hide CatalogEntry metadata representation and add stable queries for parameters, defaults, and variadic signatures
  • migrate workshop-rs internals and tests without changing parser, validation, localization, or catalog semantics
  • keep the semver gate strict for 1.x while allowing approved pre-1.0 API-hardening transitions to advance to the next 0.x compatibility line

Downstream direct-field migrations remain consumer-owned per #255.

Verification

  • cargo fmt --all --check
  • cargo test --workspace --all-targets
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo run -p workshop-rs --bin workshop-catalog-gen -- check
  • actionlint .github/workflows/ci.yml
  • git diff --check
  • independent ablation: removing param_default behavior failed the focused catalog test, then the restored implementation passed
  • cargo semver-checks check-release -p workshop-rs --release-type major

Fixes #255

BREAKING CHANGE: Catalog metadata representation is intentionally narrowed before the next 0.x compatibility line.
@e54-bot e54-bot changed the title refactor(catalog): narrow public metadata API refactor(catalog)!: narrow public metadata API Sep 22, 2026

@Teakowa Teakowa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One blocking issue.

Comment thread .github/workflows/ci.yml
@e54-bot
e54-bot requested a review from Teakowa September 22, 2026 19:06
@Teakowa
Teakowa enabled auto-merge (squash) September 22, 2026 19:10

@Teakowa Teakowa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Teakowa
Teakowa merged commit 8b573fb into main Sep 22, 2026
5 checks passed
@Teakowa
Teakowa deleted the codex/workshop-rs-255 branch September 22, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Narrow catalog public metadata to durable consumer contracts before 1.0

2 participants