feat(validate): accept any value in Boolean parameters - #288
Merged
Merged
Conversation
Boolean-typed parameters (Boolean, Boolean|Number) accept any value in canonical validation per ADR-0014; structural checks are unchanged. Number|Boolean positions keep their type check. Fixes #285
Teakowa
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #285. Parent: #283. Decision: ADR-0014 (#284).
Summary
Boolean(BooleanorBoolean|Number). Identity, arity, enum-domain, and reference-category checks are unchanged.Number|Booleanpositions are Number parameters with a Boolean alias and keep their type check; widening them has no evidence (OverPy'sFirst Ofwrapping is keyed on the Boolean parameter type).control-flow.mddescribes the rule;source-attribution/catalog.mdrecords the ADR-0014 / OverPy evidence.Tests
Teleport's Vector parameter; conformance no longer generates wrong-type cases for Boolean parameters.cargo test --workspaceandcargo clippy --workspace --all-targetspass.Not verified
The #283 probe cases depend on opy-rs emitting the reference structure.