feat(catalog): accept any value as the First Of argument - #291
Merged
Merged
Conversation
Pinned OverPy writes First Of(<value>) around values the client rejects in a Boolean parameter, so the wrapper's argument is any value, not only an array or entity ID. Declare the firstOf parameter as Any per ADR-0014 and cite the observed emission rule. Fixes #290
Teakowa
requested changes
Sep 25, 2026
Teakowa
left a comment
Contributor
There was a problem hiding this comment.
Blocking: the PR body says Fixes #290, so merging it will auto-close #290, but #290 still has an unmet acceptance criterion: after the opy-rs bump, validation-first-of-wrapper must be removed. This PR explicitly says that work remains a follow-up. Remove the auto-close reference and leave #290 open until that acceptance criterion is satisfied. The implementation/tests/CI otherwise look correct.
Teakowa
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Declare the
First Ofargument asAnyin the catalog, so canonical validation acceptsFirst Of(<any value>).Per ADR-0014, pinned OverPy 9.7.10 emits
First Of(<value>)(astToWorkshop.ts) for values the client rejects in a Boolean parameter. That deliberate emission rule is acceptance evidence for the wrapper's argument; the previousArray|EntityIdwas a presumption only.Changes
catalog.json:firstOfparamTypes[0]->Any; catalog and pinned digest regenerated.First Ofsignature updated.Verification
cargo fmt --check,cargo clippy --workspace --all-targets -D warnings,cargo test --workspace --all-targets,workshop-catalog-gen check,git diff --checkall pass.The opy-rs half (removing the
validation-first-of-wrappergap after the version bump) remains a follow-up in that repository.Refs #290 (partial: the opy-rs
validation-first-of-wrappergap removal remains, so #290 stays open).