feat!: mark Rule and Condition non_exhaustive - #293
Merged
Merged
Conversation
Keep later source-mapping and metadata fields non-breaking after 1.0 per ADR-0013. Downstream struct-literal sites migrate to Rule::new (opy-rs#359). Refs #252
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marks
RuleandCondition#[non_exhaustive]as required by the #252 comment (ADR-0013), so later mapping/metadata fields stay non-breaking in 1.x.Downstream: opy-rs builds
Rule { .. }literals at 7 sites; these migrate toRule::newin the opy-rs 1.0 candidate work. Breaking change for pre-1.0 semver-check.Verification: cargo clippy -D warnings, cargo test --workspace (354 passed).
Refs #252 (umbrella; downstream verification opy-rs#359 and wright#401 remain).