test: eliminate stdlib source warnings - #458
Closed
Donach wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Superseded by #457, which landed the warning cleanup while preserving testIsInPolygon on the Polygon API and the deliberate vector.setLengthSq warning. Closing this follow-up avoids redundant and conflicting changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #454 and #456.\n\nRemoves compiler warnings introduced when tests were moved into dedicated packages:\n- drops redundant/unused imports;\n- keeps the deprecated polygon compatibility APIs, while exercising the recommended Polygon API in the restored test;\n- preserves the TypeCasting import required by LinkedList and marks its generic conversion dependency explicitly.\n\nVerification:\n- nix develop /home/daniel/Repositories/tever/tever_main -c bash -lc 'grill test VectorsTests' — 5/5, compilation warnings: 0\n- nix develop /home/daniel/Repositories/tever/tever_main -c bash -lc 'grill test ObjectIdsTests' — 5/5, compilation warnings: 0\n- nix develop /home/daniel/Repositories/tever/tever_main -c bash -lc 'grill typecheck --quiet && grill test --quiet' — passed\n\nThe vector zero-length warning printed by testSetLengthSq is deliberate test behavior and remains unchanged.