This repository was archived by the owner on May 15, 2024. It is now read-only.
Fix Share API does not correctly block when awaited#1900
Merged
Conversation
Await on async ios UIActivityViewController
|
|
Member
|
Took us a liiiiiitle while. But this looks good to me. Thanks so much for your very first contribution @Adam-Langley ! |
jfversluis
approved these changes
May 4, 2022
1 task
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #1899 Share API does not correctly block when awaited. Should not return from async call until user has dismissed share UI.
Bugs Fixed