Skip to content
This repository was archived by the owner on May 15, 2024. It is now read-only.

Surface exception for not supported phone number on iOS PhoneDialer#1986

Merged
jfversluis merged 1 commit into
mainfrom
phonedialer-surface-exception
Apr 5, 2022
Merged

Surface exception for not supported phone number on iOS PhoneDialer#1986
jfversluis merged 1 commit into
mainfrom
phonedialer-surface-exception

Conversation

@jfversluis

Copy link
Copy Markdown
Member

Description of Change

Doesn't swallow the exception because of the async void that was going on

Bugs Fixed

API Changes

N/A

Behavioral Changes

Doesn't swallow the exception because of the async void that was going on

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Updated documentation (see walkthrough)

@jfversluis jfversluis added bug Something isn't working ios This issue impacts iOS labels Apr 4, 2022
@jfversluis jfversluis added this to the 1.7.2 milestone Apr 4, 2022
@jfversluis

Copy link
Copy Markdown
Member Author

@jamesmontemagno this seems like a small one we can also pull into 1.7.2?

@jfversluis

Copy link
Copy Markdown
Member Author

Reviewed through .NET MAUI change. If it's good enough for .NET MAUI, it's good enough for Xamarin!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working ios This issue impacts iOS

Projects

None yet

1 participant