feat(tenant): add deploy-request commands for approval workflow (DEV-7607) - #52
Draft
xano-izzy wants to merge 1 commit into
Draft
feat(tenant): add deploy-request commands for approval workflow (DEV-7607)#52xano-izzy wants to merge 1 commit into
xano-izzy wants to merge 1 commit into
Conversation
…7607) Adds the tenant_deploy_request command group (list, get, create, edit, set_status, revision, bypass) for the tenant deploy-approval workflow, and updates tenant create/edit to manage deploy_settings (required_reviewers, allow_deploy_bypass, allow_quick_deploy). tenant deploy_release now pre-checks whether a tenant requires approval and points to tenant_deploy_request create if so. Includes a live test pass against a running instance (TENANT_DEPLOY_REQUEST_TEST.md) that surfaced and fixed two real bugs: the single-tenant GET was missing deploy_settings fields, causing the deploy pre-flight check to silently no-op and tenant edit to silently wipe the approval gate on unrelated edits. Both fixed by reading tenant state via tenant list instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tenant_deploy_requestcommand group:list,get,create,edit,set_status,revision,bypasstenant create/editgaindeploy_settingsflags:--required_reviewers,--allow_deploy_bypass(create only),--allow_quick_deploytenant deploy_releasenow pre-flight checks whether the tenant requires approval and errors with guidance to usetenant_deploy_request createinstead of hitting the backend gate rawPart of DEV-7607 (tenant deployment approval workflow). Depends on the bypass-approval RBAC work in cloud-master (xano-labs/cloud-master#1030), cloud-lib (xano-labs/cloud-lib#145), and cloud-client (xano-labs/cloud-client#3247).
TENANT_DEPLOY_REQUEST_TEST.mddocuments a live test pass against a running instance, including two real bugs found & fixed during testing (single-tenanttenant getmissingdeploy_settingsfields, causing the deploy pre-flight to silently no-op andtenant editto silently wipe the approval gate on unrelated edits — both fixed by reading tenant state viatenant listinstead).Note for reviewers: that test doc's transcript also exercises a
tenant_deploy_request deletecommand, but nodeletesubcommand exists in this branch'ssrc/commands/tenant_deploy_request/. Flagging so it doesn't get missed — eitherdeleteneeds to be added, or the test doc's transcript is stale from a prior version and should be corrected.Also flagging a backend bug found during testing, not fixed here:
tenant_deploy_request revision500s server-side (Unable to locate func entry: timestamp) — blocks the "author links a newer release after changes requested" flow.Test plan
deletecommand discrepancy noted abovetenant_deploy_request create/list/get/edit/set_status/bypassagainst a gated tenant (see TENANT_DEPLOY_REQUEST_TEST.md for a worked example)tenant deploy_releaseon an ungated tenant is unaffectedbypass's success path with a token holdingtenant_center:deploy:bypass_approval