Skip to content

used xip command to extract xip - #337

Merged
segiddins merged 1 commit into
xcpretty:masterfrom
salmanasiddiqui:salmanasiddiqui-patch-1
May 28, 2019
Merged

used xip command to extract xip#337
segiddins merged 1 commit into
xcpretty:masterfrom
salmanasiddiqui:salmanasiddiqui-patch-1

Conversation

@salmanasiddiqui

Copy link
Copy Markdown
Contributor

Used xip command instead of archive utility to extract xip file

Used xip command instead of archive utility to extract xip file
@jpsim

jpsim commented May 3, 2019

Copy link
Copy Markdown
Collaborator

Do we know when xip was first added to macOS? Do we want to fallback to Archive Utility if xip isn't available?

@salmanasiddiqui

Copy link
Copy Markdown
Contributor Author

I am not sure when was it added, but it was there in osx 10.8 if you look at the bottom of man xip page. Let me know if you think we should fallback, I will update the PR accordingly

@jpsim

jpsim commented May 3, 2019

Copy link
Copy Markdown
Collaborator

Are you sure that the OS X 10.8 version supported the -x option? The manpage you linked to doesn't reference it.

@salmanasiddiqui

Copy link
Copy Markdown
Contributor Author

lol.. I am not sure.. I am not able to find --expand (-x) documented anywhere except doing man xip on my machine.

@hiroshitoda

hiroshitoda commented May 23, 2019

Copy link
Copy Markdown

-x / --expand option is documented in man since 10.14(Mojave), but enabled as a hidden option since 10.10(Yosemite) at least. I checked around that on Sauce Labs.

I faced an error on 10.14(Mojave). It seems that 10.14 Archive Utility outputs Xcode.app to ~/Downloads and has no option to output to the same directory as original .xip file.
This pull request is very welcome to me.

@jpsim jpsim left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give this a shot!

@jazaval

jazaval commented May 28, 2019

Copy link
Copy Markdown
Contributor

@jpsim I was able to install Xcode 10.2.1 on macOS 10.14.5 with these changes - is there any other functional testing I could do that would be helpful in order to move on a merge and release of this? My team and I would really benefit from this working prior to Apple's WWDC conference (and subsequent Xcode betas) next week.

@jpsim

jpsim commented May 28, 2019

Copy link
Copy Markdown
Collaborator

I think this can be merged as-is, I just don't have the permissions necessary to do so.

cc @KrauseFx

@segiddins
segiddins merged commit 5a93a6c into xcpretty:master May 28, 2019
@jazaval

jazaval commented May 30, 2019

Copy link
Copy Markdown
Contributor

@KrauseFx can this be released to rubygems as a hot fix (2.5.1?) to unblock 10.14.5 installs? If there’s any additional testing scenarios to cover I’d be happy to help.

@salmanasiddiqui

Copy link
Copy Markdown
Contributor Author

master branch has some issues. PR#338 addresses those issues.

@nancy-gomez

Copy link
Copy Markdown

Hello any updates on when this change will be released? Got hit with this regarding Xcode 11 Beta 3, then tested with non-beta version Xcode 10.2 and same thing. There seems to be an issue with Archive Utility's ability to expand the xip file. Currently doing the --no-install and xip command work-around but would much rather be able to use a patch with this change :)

@salmanasiddiqui
salmanasiddiqui deleted the salmanasiddiqui-patch-1 branch July 15, 2019 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants