Bug: Error in `fetch-share-url` command

[damsfx]

Description

Got an php error when trying to retrieve share url.

Steps To Reproduce

Run

> valet share
Sharing mysite.local...

To output the public URL, please open a new terminal and run `valet fetch-share-url mysite.local`

And then

>  valet fetch-share-url mysite.local
Trying to retrieve tunnel URL...
PHP Fatal error:  Uncaught Error: Call to undefined function Valet\retry() in C:\Users\Name\AppData\Roaming\Composer\vendor\ycodetech\valet-windows\cli\Valet\ShareTools\ShareTool.php:84
Stack trace:
#0 C:\Users\Name\AppData\Roaming\Composer\vendor\ycodetech\valet-windows\cli\valet.php(975): Valet\ShareTools\ShareTool->currentTunnelUrl('mysite.loca...')
#1 [internal function]: Valet\Application->{closure}('mysite.loca...')
#2 C:\Users\Name\AppData\Roaming\Composer\vendor\php-di\invoker\src\Invoker.php(74): call_user_func_array(Object(Closure), Array)
#3 C:\Users\Name\AppData\Roaming\Composer\vendor\mnapoli\silly\src\Application.php(95): Invoker\Invoker->call(Object(Closure), Array)
#4 C:\Users\Name\AppData\Roaming\Composer\vendor\symfony\console\Command\Command.php(324): Silly\Application->Silly\{closure}(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#5 C:\Users\Name\AppData\Roaming\Composer\vendor\symfony\console\Application.php(1098): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#6 C:\Users\Name\AppData\Roaming\Composer\vendor\symfony\console\Application.php(324): Symfony\Component\Console\Application->doRunCommand(Object(Silly\Command\Command), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#7 C:\Users\Name\AppData\Roaming\Composer\vendor\symfony\console\Application.php(175): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#8 C:\Users\Name\AppData\Roaming\Composer\vendor\ycodetech\valet-windows\cli\valet.php(1533): Symfony\Component\Console\Application->run()
#9 C:\Users\Name\AppData\Roaming\Composer\vendor\ycodetech\valet-windows\valet(103): require('C:\\Users\\Name...')
#10 C:\Users\Name\AppData\Roaming\Composer\vendor\bin\valet(119): include('C:\\Users\\Name...')
#11 {main}

It's strange, because the helpers seem to be loading correctly with autoload.

Possible solution.

Remove the use of Valet\retry (use function Valet\retry) and keep the Laravel default helper.

[yCodeTech]

I think Valet's retry helper is undefined because its wrapped in a conditional and it only gets defined if laravel's retry is not available. But then if it is defined, Valet doesn't resolve the helper to use laravel's function, which is why its erroring.

To be fair, looking at the Valet macOS versions code, they don't use laravels helper, just Valet's own function without it wrapped in conditional (it was removed in laravel@78d0398).

https://github.com/laravel/valet/blob/cffa84001ad54f89a5cd6901dde37e98bb5ddea3/cli/includes/helpers.php#L115

I will look at this at the same time as updating the version so there isn't just a version number update release.

It is very interesting that this command has only just started to error, all previous testing and usages of the command worked without fail.

[yCodeTech]

I can't replicate this bug. I can only replicate it if I add another retry function elsewhere but in the global scope instead of namespaced, then I get the error. So I guess it depends on if the Laravel helpers are included in a composer global package.

I don't think using the default Laravel helper will be a good solution since not all helpers are packaged with the illuminate component packages, so not all installs will have the required default helpers (like me). And requiring the Support package (where they are defined) in Valet, would technically be code bloat since only 5% of the package would be in use.

I'll fix the issue by removing the conditionals, which would also be enhancing the code parity too with macOS version.

[yCodeTech]

Please update to v3.4.3, thanks.

[damsfx]

I can't replicate this bug. I can only replicate it if I add another retry function elsewhere but in the global scope instead of namespaced, then I get the error. So I guess it depends on if the Laravel helpers are included in a composer global package.

Yes, after looking into it further, I think this is the case.

I don't think using the default Laravel helper will be a good solution since not all helpers are packaged with the illuminate component packages, so not all installs will have the required default helpers (like me). And requiring the Support package (where they are defined) in Valet, would technically be code bloat since only 5% of the package would be in use.

You’re absolutely right.

Thank you for providing this quick update.