Custom serializer#100
Conversation
Gerych1984
commented
Jan 21, 2026
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ❌ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #100 +/- ##
=========================================
Coverage 91.56% 91.56%
- Complexity 69 70 +1
=========================================
Files 1 1
Lines 166 166
=========================================
Hits 152 152
Misses 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
samdark
left a comment
There was a problem hiding this comment.
I like the idea very much. Please add a line for CHANGELOG.md, tests and docs. Thanks.
| "php": "8.1 - 8.5", | ||
| "psr/simple-cache": "^2.0 || ^3.0" | ||
| "psr/simple-cache": "^2.0 || ^3.0", | ||
| "yiisoft/cache": "^3.2" |
There was a problem hiding this comment.
It is not required for this package to function as PSR cache implementation.
There was a problem hiding this comment.
then I don't understand how to throw the interface into the caches.
There was a problem hiding this comment.
With the current implementation, your approach is fine.
|
Overall approach looks fine. So would you please add tests and a line for a changelog? Thanks. |