Skip to content

Fix multiline default string#295

Merged
samdark merged 5 commits into
yiisoft:masterfrom
Tigrov:multiline_default_string
Jul 24, 2023
Merged

Fix multiline default string#295
samdark merged 5 commits into
yiisoft:masterfrom
Tigrov:multiline_default_string

Conversation

@Tigrov

@Tigrov Tigrov commented Jul 21, 2023

Copy link
Copy Markdown
Member
  • Fix multiline default value of string / text
  • Fix single quote in default value
Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues -

@what-the-diff

what-the-diff Bot commented Jul 21, 2023

Copy link
Copy Markdown

PR Summary

  • Enhancement in Schema Handling
    A modification has been made in our schema handling system, specifically Schema.php which includes a new rule for managing default values. This new rule effectively trades extra quotes in the default value for single quotes.
  • Update in SchemaProvider.php
    The defaultValue for char_col has been updated to a certain value ('some\'thing'). Plus, a new character column (char_col4) is introduced which will hold multi-line default values.
  • Adjustment in SQL Database Management
    In our database management file pgsql.sql, several changes are done: the defaultValue of char_col2 has been changed to 'some\'thing'. Also like previously mentioned change, we added another character column (char_col4) that takes multi-line default values.

@codecov

codecov Bot commented Jul 21, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (56df5ac) 99.83% compared to head (edff453) 99.83%.

❗ Current head edff453 differs from pull request most recent head cfba6e8. Consider uploading reports for the commit cfba6e8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #295   +/-   ##
=========================================
  Coverage     99.83%   99.83%           
  Complexity      202      202           
=========================================
  Files            13       13           
  Lines           601      602    +1     
=========================================
+ Hits            600      601    +1     
  Misses            1        1           
Impacted Files Coverage Δ
src/Schema.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Tigrov Tigrov marked this pull request as ready for review July 21, 2023 10:08

@vjik vjik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add line to changelog

@vjik vjik requested review from darkdef and terabytesoftw July 21, 2023 11:53
@vjik vjik added the status:code review The pull request needs review. label Jul 21, 2023
@vjik

vjik commented Jul 23, 2023

Copy link
Copy Markdown
Member

@Tigrov Need test for negative numeric default values whose support has been added by last commit. And add info about it to changelog also.

@samdark

samdark commented Jul 24, 2023

Copy link
Copy Markdown
Member

Created an issue for adding a test not to block release: #298

@samdark samdark merged commit 2e00673 into yiisoft:master Jul 24, 2023
@samdark

samdark commented Jul 24, 2023

Copy link
Copy Markdown
Member

👍

@Tigrov Tigrov deleted the multiline_default_string branch July 24, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants