Refactor ColumnSchema.php#302
Conversation
Tigrov
commented
Jul 25, 2023
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Fixed issues | - |
PR Summary
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #302 +/- ##
=============================================
+ Coverage 99.83% 100.00% +0.16%
+ Complexity 201 200 -1
=============================================
Files 13 13
Lines 599 596 -3
=============================================
- Hits 598 596 -2
+ Misses 1 0 -1
☔ View full report in Codecov by Sentry. |
* Refactor ArrayExpressionBuilder.php * Update * Update `InvalidArgumentException` message * Remove extra check, PDO will throw an exception * Change type of params from `ArrayExpression` to `ExpressionInterface` * Update * Update * Correct `getTypehint` to `getTypeHint` * Change ExpressionInterface to ArrayExpression * Change @param ArrayExpression $expression and add changelog * Remove @psalm-param ArrayExpression $expression * Update CHANGELOG.md --------- Co-authored-by: Sergei Predvoditelev <sergey.predvoditelev@gmail.com>
Co-authored-by: Sergei Predvoditelev <sergey.predvoditelev@gmail.com>
Co-authored-by: Sergei Predvoditelev <sergey.predvoditelev@gmail.com>
…actor_column_schema # Conflicts: # src/ColumnSchema.php
Co-authored-by: Sergei Predvoditelev <sergey.predvoditelev@gmail.com>
|
For view correct changes in this PR use this link: master...Tigrov:refactor_column_schema |
|
Seems, static analysis fail in CI because used non-stable version of |
|
👍 |
This reverts commit 4119262.