Skip to content

Load column properties via constructor#366

Merged
Tigrov merged 3 commits into
masterfrom
remove-load-from-column
Oct 18, 2024
Merged

Load column properties via constructor#366
Tigrov merged 3 commits into
masterfrom
remove-load-from-column

Conversation

@Tigrov

@Tigrov Tigrov commented Oct 18, 2024

Copy link
Copy Markdown
Member

Related PR

Q A
Is bugfix?
New feature? ✔️/❌
Breaks BC? ✔️/❌
Fixed issues

@codecov

codecov Bot commented Oct 18, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 97.22222% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.73%. Comparing base (82efe1a) to head (224b10c).

Files with missing lines Patch % Lines
src/Column/ColumnFactory.php 94.11% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #366      +/-   ##
============================================
- Coverage     99.74%   99.73%   -0.01%     
- Complexity      254      256       +2     
============================================
  Files            27       27              
  Lines           777      768       -9     
============================================
- Hits            775      766       -9     
  Misses            2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov merged commit 4f85a22 into master Oct 18, 2024
@Tigrov Tigrov deleted the remove-load-from-column branch October 18, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants