Skip to content

Deprecate abstract type SchemaInterface::TYPE_JSONB#765

Merged
Tigrov merged 2 commits into
yiisoft:masterfrom
Tigrov:deprecate_type_jsonb
Oct 14, 2023
Merged

Deprecate abstract type SchemaInterface::TYPE_JSONB#765
Tigrov merged 2 commits into
yiisoft:masterfrom
Tigrov:deprecate_type_jsonb

Conversation

@Tigrov

@Tigrov Tigrov commented Oct 10, 2023

Copy link
Copy Markdown
Member

jsonb is an incorrect abstract type. It is a specific json type of PorstgeSQL

See comment #723 (comment)

Repated PR: yiisoft/db-pgsql#319

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

@codecov

codecov Bot commented Oct 10, 2023

Copy link
Copy Markdown

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a60a912) 99.73% compared to head (fbd6afd) 93.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #765      +/-   ##
============================================
- Coverage     99.73%   93.00%   -6.73%     
  Complexity     1268     1268              
============================================
  Files            63       67       +4     
  Lines          3045     3061      +16     
============================================
- Hits           3037     2847     -190     
- Misses            8      214     +206     

see 32 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov changed the title Deprecate SchemaInterface::TYPE_JSONB Deprecate abstract type SchemaInterface::TYPE_JSONB Oct 10, 2023
@Tigrov Tigrov marked this pull request as ready for review October 10, 2023 10:55
@Tigrov Tigrov requested a review from terabytesoftw October 10, 2023 10:55
Comment thread src/Schema/SchemaInterface.php
@Tigrov Tigrov merged commit 071f46a into yiisoft:master Oct 14, 2023
@Tigrov Tigrov deleted the deprecate_type_jsonb branch October 14, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants