Skip to content

Refactor column PHP type#862

Merged
Tigrov merged 10 commits into
masterfrom
refactor-column-php-type
Aug 9, 2024
Merged

Refactor column PHP type#862
Tigrov merged 10 commits into
masterfrom
refactor-column-php-type

Conversation

@Tigrov

@Tigrov Tigrov commented Aug 8, 2024

Copy link
Copy Markdown
Member

@codecov

codecov Bot commented Aug 8, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 98.24561% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.61%. Comparing base (23e8d43) to head (19adfb4).

Files Patch % Lines
src/Schema/AbstractSchema.php 95.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master     #862       +/-   ##
=============================================
+ Coverage     85.06%   99.61%   +14.54%     
- Complexity     1369     1372        +3     
=============================================
  Files            74       74               
  Lines          3369     3362        -7     
=============================================
+ Hits           2866     3349      +483     
+ Misses          503       13      -490     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov requested a review from vjik August 9, 2024 06:51
@Tigrov Tigrov added the status:code review The pull request needs review. label Aug 9, 2024
Comment thread src/Constant/PhpType.php Outdated
Comment thread src/Constant/GettypeResult.php Outdated
Comment thread src/Schema/Column/ColumnSchemaInterface.php
@Tigrov Tigrov merged commit 6a8ceea into master Aug 9, 2024
@Tigrov Tigrov deleted the refactor-column-php-type branch August 9, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants