Skip to content

Added build and deploy for non-linux user - #2

Open
ifew wants to merge 27 commits into
zaccharles:masterfrom
ifew:master
Open

Added build and deploy for non-linux user#2
ifew wants to merge 27 commits into
zaccharles:masterfrom
ifew:master

Conversation

@ifew

@ifew ifew commented Apr 19, 2019

Copy link
Copy Markdown

using docker for build

@zaccharles

Copy link
Copy Markdown
Owner

Hey @ifew

Thanks for this!

Do you think it might be better to create a new build script for the Docker build, maybe named build-docker.sh?

@ifew

ifew commented Apr 22, 2019

Copy link
Copy Markdown
Author

OK, that's Interesting

@ifew

ifew commented Apr 24, 2019

Copy link
Copy Markdown
Author

Hey @ifew

Thanks for this!

Do you think it might be better to create a new build script for the Docker build, maybe named build-docker.sh?

I already push build-docker.sh for build docker image.

@zaccharles

Copy link
Copy Markdown
Owner

Hi,

What I was hoping to see is that build.sh should not have anything from Docker. It should be for building without Docker because Docker isn't required. build-docker.sh should contain everything needed to build with Docker.

@ifew

ifew commented Apr 24, 2019

Copy link
Copy Markdown
Author

Ahh, I see. sorry for misunderstanding

@ifew ifew closed this Apr 24, 2019
@ifew ifew reopened this Apr 24, 2019
@ifew ifew closed this Nov 13, 2019
@ifew

ifew commented Nov 13, 2019

Copy link
Copy Markdown
Author

Fixed for solve AWS Lambda Connection timeout 100ms

@ifew ifew reopened this Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants