EZSP v18 support - #704
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #704 +/- ##
=======================================
Coverage 99.53% 99.54%
=======================================
Files 58 61 +3
Lines 4128 4147 +19
=======================================
+ Hits 4109 4128 +19
Misses 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
puddly
force-pushed
the
puddly/ezsp-v18
branch
from
January 2, 2026 00:33
86153eb to
da98c6a
Compare
puddly
force-pushed
the
puddly/ezsp-v18
branch
from
January 2, 2026 00:41
0236a63 to
370e08c
Compare
TheJulianJES
approved these changes
Jan 2, 2026
mineshaftgap
pushed a commit
to mineshaftgap/bellows
that referenced
this pull request
Jun 11, 2026
* EZSP v18 * Remove unused `_handle_no_such_device` * Move packet reception logic into the protocol handler * Add to EZSP config * Add a new test for v18 * Properly handle event lifecycle * Migrate to events * Revert unit test changes * Remove unnecessary unit tests * Fix tests * Revert EmberApsFrameV18 addition * Use dicts for tests * Migrate the rest to events * Use named callbacks to avoid duplication * Remove unnecessary proxy methods * Bring coverage up * Reduce diff size * Fix new unit test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EZSP v18 changed the format of APS frames. To account for this, I've moved more processing into the protocol-specific handlers and have switched to the zigpy event bus for these new events.As it turns out, the struct indeed changed...but the wire format was never updated to account for the new fields. If you use then, the coordinator crashes 😄. So this protocol version bump is effectively just changing a single parameter in a command we do not use from
uint8_ttouint16_t.