the `useDefaultIfNull` paramter in `ToCharOrDefault` method is useless

[Sunzhuokai]

https://github.com/zzzprojects/Z.ExtensionMethods/blob/master/src/Z.Core/System.Object/Convert/ToValueType/Object.ToCharOrDefault.cs#L53
Convert.ToChar(null) will throw a ArgumentNullException，So no matter the useDefaultIfNull is true or false the defaultValue always return

[Sunzhuokai]

Same as Guid

[JonathanMagnan]

Hello @Sunzhuokai ,

Thank you for reporting,

We will look at it since the pull provided seems to change the default behavior.

Best Regards,

Jonathan

---

Help us to keep this library free: Donate

[JonathanMagnan]

Hello @Sunzhuokai ,

After investigating this issue, we found at that

Convert.ToChar(null)

throw an error since the null constant is used.

However, when using a variable such as

object obj = null;
var ch = Convert.ToChar(obj);

No error is thrown.

Unless I'm wrong, the method works as intended and adding the change from your pull will do nothing since a parameter is used and not a null constant.

Let me know if the explanation is clear enough .

Best Regards,

Jonathan

---

Help us to keep this library free: Donate

[Sunzhuokai]

I mean the 'useDefaultIfNull' parameter is useless

object obj = null;
obj.ToCharOrDefault('a',true); // return 'a'
obj.ToCharOrDefault('a',false);  // return 'a'

[JonathanMagnan]

Hello @Sunzhuokai ,

That's not what my test is returning me.

object obj = null;
var ch1 = obj.ToCharOrDefault('a', true); // return 'a'
var ch2 = obj.ToCharOrDefault('a', false);  // return '\0'

There is a big difference on my side.

Best Regards,

Jonathan

[Sunzhuokai]

you are right