Add cloud platform related guidance in readme - #27
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughAdds bilingual README instructions for optional S3-backed LanceDB storage, including cloud dependencies, environment configuration, environment loading, gateway startup with production or test profiles, and data querying guidance. ChangesCloud storage documentation
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
README.md (1)
209-217: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winScope HTTP S3 access to test/local usage. Both examples unconditionally set
WT_SDK_S3_ALLOW_HTTP=true, including production guidance. Verify the SDK semantics and keep this disabled or omitted for production profiles.
README.md#L209-L217: split production and test examples so production does not enable HTTP.README_CN.md#L201-L209: apply the same security correction in the Chinese example.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@README.md` around lines 209 - 217, Update the environment-variable examples in README.md (lines 209-217) and README_CN.md (lines 201-209) to separate production and test/local guidance: omit or disable WT_SDK_S3_ALLOW_HTTP for production profiles while retaining it only for test/local usage, consistent with the SDK’s semantics.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@README.md`:
- Around line 209-217: Update the environment-variable examples in README.md
(lines 209-217) and README_CN.md (lines 201-209) to separate production and
test/local guidance: omit or disable WT_SDK_S3_ALLOW_HTTP for production
profiles while retaining it only for test/local usage, consistent with the SDK’s
semantics.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 89d96dc4-e66d-4c4d-9973-040230ea965b
📒 Files selected for processing (2)
README.mdREADME_CN.md
WangXuhongCN
left a comment
There was a problem hiding this comment.
LGTM with tiny changes
Summary by CodeRabbit
productionvstestselect corresponding data tables, and expanded the linked reference to cover querying and data retrieval.