Skip to content

update wt-sdk tag to include dldb multi version issue fix - #33

Merged
WangXuhongCN merged 1 commit into
AI45Lab:v2from
hsballoon:dldbVerFix
Jul 30, 2026
Merged

update wt-sdk tag to include dldb multi version issue fix#33
WangXuhongCN merged 1 commit into
AI45Lab:v2from
hsballoon:dldbVerFix

Conversation

@hsballoon

@hsballoon hsballoon commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Documentation

    • Added Python version requirements for optional S3 and LanceDB storage setup.
    • Clarified that Python 3.12 is the currently verified environment in English and Chinese guides.
  • Chores

    • Updated cloud dependency installation guidance for reproducible setup with Python 3.10–3.12.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The optional S3 and LanceDB setup now documents Python 3.10–3.12 support, identifies Python 3.12 as verified, and pins wt-data-platform-sdk to GitHub tag v0.1.0.

Changes

Cloud dependency setup

Layer / File(s) Summary
Dependency pin and setup guidance
requirements-cloud.txt, README.md, README_CN.md
The cloud SDK dependency now uses GitHub tag v0.1.0, and both setup guides document the supported Python versions and verified Python 3.12 environment.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • AI45Lab/SAfactory#27: Updates the same optional S3 and LanceDB setup guidance and related SDK environment configuration.

Suggested reviewers: binhuangpjlab

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the dependency tag update and fix-focused intent of the change, even though it omits the documentation updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
requirements-cloud.txt (1)

5-5: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick win

Pin an immutable commit for reproducibility.

@v0.1.0 identifies a tag, which can be retargeted; pin the tag’s full commit SHA instead if reproducible installs are a hard requirement. (git-scm.com)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@requirements-cloud.txt` at line 5, Update the wt-data-platform-sdk dependency
specification to reference the full immutable commit SHA corresponding to v0.1.0
instead of the mutable tag, preserving the existing repository URL and package
dependency.

Source: MCP tools

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@requirements-cloud.txt`:
- Line 5: Update the wt-data-platform-sdk dependency specification to reference
the full immutable commit SHA corresponding to v0.1.0 instead of the mutable
tag, preserving the existing repository URL and package dependency.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 75a34ea0-8807-4fee-b55f-f6a016c61750

📥 Commits

Reviewing files that changed from the base of the PR and between e65011c and a4b6cce.

📒 Files selected for processing (3)
  • README.md
  • README_CN.md
  • requirements-cloud.txt

@hsballoon

Copy link
Copy Markdown
Collaborator Author

Notes:
为避免已运行python进程中老代码cache的干扰,请force reinstall:
python -m pip install
--upgrade
--force-reinstall
--no-cache-dir
-r requirements-cloud.txt

然后重启worker进程。

@WangXuhongCN WangXuhongCN left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants