DF 54.1 only: remove deltalake/delta feature; RP-SEAL charter; profile.dev debug=0 - #962
Merged
AdaWorldAPI merged 9 commits intoAug 18, 2026
Merged
Conversation
…, and the C-band The contract's mirror of OGAR's ConceptDomain ended at Geo (0x0F) while OGAR carries Ontology (0x03, populated by the DisMech 0x0333 mints), Blocks (0x17), and the C-band JavaRuntime/Analytics/BinaryLifting (0xC0/0xC1/0xC4 -- the altitude ruling, OGAR #276+#277; 0xC0 is Panama FFM alone, Valhalla being a property of the C0 vocabulary rather than an addressable concept). Both sides' docs demand they update together; this is the catch-up, found by the lance-graph-java session and verified independently by the ruff/R2IL session at db488f5, with ownership of the sync explicitly handed here so the ruff arc's PR3 rebases trivially. The real finding is WHY the drift guard never fired: domains_agree + assert_codebook_parity only walk ids that carry concept rows, so a reserved-EMPTY domain added to one enum but not the other is invisible to a content walk. Proven live -- the first disable-run (dropping the new BinaryLifting pair from domains_agree) stayed GREEN. Repaired with reserved_empty_domains_agree_across_the_mirror: one id per new domain, the populated 0x0333, the deliberate 0xC2-0xC3 gap pinned like OGAR's own 0x10-0x16, the band edges, and the 0x0C/0xC0 digit-swap two-sided. Both disable-runs (bridge pair dropped; contract arm dropped) now go red on exactly that test; the contract's own domain_routes_on_high_byte independently catches the arm removal. Gates: lance-graph-contract 1162/1162 + doctests, clippy --all-targets clean; lance-graph-ogar (workspace-excluded, tested via manifest-path) 64/64 incl. assert_codebook_parity green -- content parity holds, this was domain-level drift only. The crate's 11 pre-existing clippy warnings are measured identical with this diff stashed and left untouched. Board: EPIPHANIES E-OGAR-CODEBOOK-MIRROR-DOMAIN-DRIFT-SYNCED-1 prepended in the same commit, per the board-hygiene rule.
Research charter deliverables 1-2 (no fix included, by design): - docs/lotus/LOTUS-FRONTIER-AUDIT.md — Phase 0 archaeology across the write path, persistence capability, placement/comma prior art, and frontier visibility, every statement graded VERIFIED / INFERENCE / HYPOTHESIS / BLOCKER. Headline findings: content_hash folds arrival-minted stream_position values into batch_hash (persist_sink.rs:414), contradicting DetachedCycleBatch's own order-independence doc; the seal is O(batch bytes) x3 passes with the batch resident up to 3x at seal; SweepSlot's caller-supplied semantic order-key contract vs collect_casts' arrival mint; the lance crate source is absent from this sandbox (prepared-artifact capability audit BLOCKED). Section 6 answers the permeability question: the cycle does not become permeable, it becomes thin — trailing-publication pipelining (Regime A) needs no epistemic weakening; rung-qualified frontier visibility (temporal.rs EpistemicMode ladder) stratifies rather than reopens the retired race; texts stay linear, tiles get derived placement, resolved per class. - docs/lotus/F-ORD-REAL-FALSIFIER.md — the defect mechanism in four verified steps + the test design (perturb the process that creates the key: permute cast() call order, never post-mint slots). - cycle_driver.rs tests: f_ord_real_defect_pin_... (GREEN, two-sided — anti-vacuity proves the perturbation reaches the key mint; semantic set + image pinned arrival-independent; batch_hash pinned arrival-DEPENDENT; fails loudly when a fix lands) and f_ord_real_publication_identity_... (#[ignore]d RED falsifier — the desired property, red under --ignored on the real chain). Gates: cargo test -p lance-graph-supervisor --features cycle-driver 28 passed / 1 ignored (+ suites green); RED verified red under --ignored; fmt clean; clippy adds zero new warnings (8 pre-existing recover_fleet lints only visible under this non-default feature). Board: EPIPHANIES E-FORD-REAL-PUBLICATION-IDENTITY-IS-ARRIVAL-DEPENDENT-1; STATUS_BOARD lotus-seal-fractal-commit-frontier section (D-LOTUS-1..9). Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…EAL charter + boards Ruling (E-PIN-LANCE9-LANCEDB033-DF541-ARROW58-NO-DF53-1): lance 9 / lancedb 0.33 / datafusion 54.1 (no DF 53) / arrow 58, always, across AdaWorldAPI forks, usually via [patch -> upstream repository git]. Measured before acting: the only DF-53 source was deltalake 0.32.4 (^53.1.0) behind the already-non-default, already-broken delta feature; registry check shows no DF-54 deltalake exists. Removed: delta feature, deltalake + url optional deps, DeltaTableReader (module docs + Cargo.toml carry dated removal notes; DataSourceFormat::Delta stays as a catalog tag). Post-removal Cargo.lock: exactly ONE datafusion = 54.1.0, zero deltalake entries. cargo check -p lance-graph green; fmt clean; full suite running as the PR gate. Docker pins surveyed: root + avx512 = Rust 1.97.1 + protobuf-compiler, no delta references — removal is docker-safe (stale flag noted: crates/symbiont/Dockerfile rust:1.95). Also: RP-SEAL research charter committed as .claude/plans/erasure-seals-compaction-research-v1.md (15-researcher program, independent pass dispatched as background workflow wf_ca974718-1b4; adversaries strongest-tier, builders/scouts grindwork tier); INTEGRATION_PLANS + STATUS_BOARD entries; D-LOTUS-6 BLOCKER lifted (operator-sanctioned upstream-git source consult; exact v9.0.0 tag on disk matching the lock checksum) with the audit carrying the dated lift note; CLAUDE.md 'BOTH MAJORS ARE REQUIRED' note superseded in place. Co-Authored-By: Claude <noreply@anthropic.com>
…t deprecated (#879/#911/#912/#913) Recorded in the RP-SEAL plan header + the pin-ruling EPIPHANIES entry; the workflow script was corrected in place (source map + the two cell briefs naming rustynum); the in-flight independent pass could not be force-stopped in this harness build, so the ruling binds consolidation as a hard filter. Deltalake removal ratified same exchange. Co-Authored-By: Claude <noreply@anthropic.com>
…ow 58
Operator-pointed, verified from delta-io/delta-rs main Cargo.toml
(datafusion = 54.0.0, arrow = 58): only the crates.io releases top out at
DF 53. Restoration is available now via a git-pin on upstream + a reader
refactor to the current builder API — as its own deliberate PR if a
consumer needs Delta. The removal itself stands on the need ruling
('we don't need deltalake'), not on availability; notes in Cargo.toml,
CLAUDE.md, and the EPIPHANIES entry corrected accordingly.
Co-Authored-By: Claude <noreply@anthropic.com>
Full-debuginfo test binaries grew target/ to 17 GB and SIGBUS'd the linker on a full disk this session; debug=0 shrinks the lance/datafusion-stack test binaries ~an order of magnitude. Matches the gate already running with CARGO_PROFILE_DEV_DEBUG=0 (same resolved profile, cache reuse). line-tables-only noted as the fallback if line-numbered backtraces are ever needed. Co-Authored-By: Claude <noreply@anthropic.com>
AdaWorldAPI
marked this pull request as ready for review
August 18, 2026 22:17
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_3728a678-7543-49c9-8fa2-6fa8d22cf3e8) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pin ruling, discharged
Operator ruling: lance 9 / lancedb 0.33 / datafusion 54.1 (no DF 53) / arrow 58, always, across AdaWorldAPI forks — usually consumed via
[patch]of the upstream repository git. DF 53 existed only for older syntax in an out-of-scope research crate; all of lance-graph is DF-54-certified, and a single DF major is "much better, easier, faster to handle".Measured before acting: the lock carried both 53.1.0 and 54.1.0; the only DF-53 source was
deltalake 0.32.4(^53.1.0) behind thedeltafeature — which was already non-default and already documented broken (deltalake 0.32 removedDeltaTableProvider::try_new; the reader was never refactored).Removed:
deltafeature,deltalake+urloptional deps,DeltaTableReader.DataSourceFormat::Deltastays (a catalog metadata tag). Post-removalCargo.lock: exactly ONE datafusion = 54.1.0, zero deltalake entries.Does this cost us ACID? No — verified, not assumed
Our persistence path is
cycle_sink.rs→ LanceDataset::write/appendexclusively; the removed feature was a read-sideTableReaderfor querying external Delta tables via DataFusion. Lance 9.0.0 supplies the ACID mechanics we use, verified in the pinned source (lance-table/src/io/commit.rs): atomicity via write-once manifest commit (ConditionalPutCommitHandlerdefault,:1078/:1095; rename/lock/DynamoDB handlers also present), snapshot isolation via versioned manifests, durability via object-store put + manifest. Consistency is deliberately ours and above any store ((cycle, batch_hash)fence,Fenced/HashConflictfail-closed,guard_schema, one-logical-writer).Correction carried in the notes: delta-rs main already pins
datafusion = 54.0.0+arrow = 58— only the crates.io releases top out at DF 53. So restoration is available now (git-pin on upstream + a reader refactor to the current builder API), as its own deliberate PR if a consumer needs Delta. The removal stands on the need ruling, not on availability.Also in this PR
.claude/plans/erasure-seals-compaction-research-v1.md, the operator's 15-researcher program (5 domains × builder/adversary/scout) on bidirectional erasure-coded seals + locality-aware compaction, with the mid-dispatch scope pivot recorded: rustynum struck (everything ndarray),crates/symbiontdeprecated per the D-MBX-A6-P4: cycle loop-closure driver — sparse seal/apply + MUL-gate thought seam (control-loop contract) #879/graph/cycle_sink: the concrete Lance-backed WalSink — storage-proven cognitive-cycle sink (§I.6) #911/Phase A: artifact-backed commits + the sole owned Lance writer (supersedes the #911 cycle contract) #912/persistence follow-up gates: publication vs observed head, enforceable fences #913 arc.[profile.dev] debug = 0— full-debuginfo test binaries grewtarget/to 17 GB and SIGBUS'd the linker on a full disk this session; debug=0 shrinks the lance/datafusion-stack test binaries ~an order of magnitude and links faster.CLAUDE.md— the old "BOTH MAJORS ARE REQUIRED — do NOT fix Cargo.lock to one" datafusion note superseded in place (it was written whendeltawas default and load-bearing).Test plan
cargo test -p lance-graph(debug=0): 1,312 passed, 0 failed, 14 ignored across 20 suitescargo check -p lance-graphgreen;cargo fmtcleanCargo.lock: one datafusion (54.1.0), zero deltalakeBoard (same commits): EPIPHANIES
E-PIN-LANCE9-LANCEDB033-DF541-ARROW58-NO-DF53-1, STATUS_BOARD RP-SEAL section, INTEGRATION_PLANS entry.🤖 Generated with Claude Code
https://claude.ai/code/session_017Pud4qpxFHwqyqDjSabQbs
Generated by Claude Code