ogar_codebook: retract the 14 hallucinated 0x03XX Ontology mirror rows (fixes CI on #997/#998) - #999
Conversation
Audit finding (verified against a freshly-synced OGAR main, not the stale local clone this session started with): commit ae8e762 mirrored 14 "Ontology" concepts (mondo/hpo/uberon/pato/ro + the meta-study spine) into this crate's CODEBOOK under a doc comment claiming "operator ruling: the domains should be minted in ogar-vocab" and "DeepNSM-v2 wired: deepnsm::ontology_vocab". Neither claim was ever true: - OGAR's ogar-vocab has never once minted a 0x03XX CODEBOOK row. Its only commit touching the block (e9a2e45, 2026-08-01 -- three weeks BEFORE the mirror commit) is "reserve 0x03 Ontology domain (plug-and-play, zero rows)" -- explicitly the OPPOSITE posture, unchanged on current OGAR main: "Carries ZERO shared vocabulary rows... Do NOT mint rows here." - `deepnsm` has no `ontology_vocab` module and no reference anywhere in its source to `ogar_codebook`, `ConceptDomain`, or `concepts_in_domain`. This is exactly the drift `lance-graph-ogar::parity:: mirror_is_a_faithful_copy_of_ogar_codebook` exists to catch, and it did: CI's "test" job has been failing on every PR since (confirmed on both #997 and #998, unrelated example-only PRs that inherited the broken main via their base SHA). Fix, smallest boundary: - Remove the 14 rows; restore the 0x03XX block to OGAR's actual, unchanged "reserved, zero vocabulary rows" posture. No OGAR-side change needed or made -- OGAR was never wrong. - Correct the two doc comments that repeated the false claim (`concepts_in_domain`'s doc, the CODEBOOK block comment) and the one test that asserted the hallucinated content (`concepts_in_domain_answers_for_ontology_and_stays_silent_for_a_reserved_block`, now asserts Ontology returns empty like Osint, with ProjectMgmt as the populated-domain anti-vacuity check instead). - Same correction to a stray comment in lance-graph-ogar's own `reserved_empty_domains_agree_across_the_mirror` test (referenced a nonexistent "0x0333 DisMech" mint -- same class of stale-context claim, harmless to the assertion since it only checks domain-tag agreement, but misleading). - Rename the CI step "Run lance-graph-ogar fuse tests" to "... codebook-parity + hotplug-activation tests" and correct its comment (still referenced the compile-time COUNT_FUSE, retired 2026-08-14). Explicitly NOT touched: OGAR (read-only from here, and it was never wrong); the 4 C-band domains (Weather/JavaRuntime/Analytics/ BinaryLifting) -- these looked like a second instance of the same drift against a stale local OGAR clone (frozen at PR #265), but after fast-forwarding to origin/main (PR #281) they are confirmed real, OGAR-side, operator-ruled (PR #276/#277, 2026-08-18), and correctly mirrored. False alarm, recorded here so it isn't re-investigated. Verified: `cargo test --manifest-path crates/lance-graph-contract/Cargo.toml --lib ogar_codebook` green (15/15). Full `lance-graph-ogar` suite pending a local disk-space recovery (session tmpfs exhausted mid-verification) -- CI on this PR is the first full confirmation. Note: `.claude/board/EPIPHANIES.md` is NOT updated in this commit -- it exceeds the 1MB API fetch limit and this session's git/Bash access is currently down, so a safe byte-exact prepend isn't possible right now. This violates the repo's same-commit board-hygiene rule deliberately, once, rather than risk corrupting an append-only governance file. Follow-up needed once tooling recovers.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_2da04811-2ef9-4724-861c-230a9b4fea80) |
What broke
mirror_is_a_faithful_copy_of_ogar_codebook(lance-graph-ogar::parity) has been failing CI'stestjob on every PR since commitae8e762e(2026-08-22), which mirrored 14 "Ontology" concepts (mondo/hpo/uberon/pato/ro+ the meta-study spinebfo/cob/iao/obi/obcs/sepio/eco/fbbi) intolance-graph-contract'sCODEBOOK, under a doc comment claiming "operator ruling: the domains should be minted in ogar-vocab" and "DeepNSM-v2 wired:deepnsm::ontology_vocab".Neither claim was ever true, verified against a properly-synced
origin/main:ogar-vocabhas never once minted a0x03XXCODEBOOKrow. Its only commit touching that block (e9a2e45, 2026-08-01 — three weeks before the mirror commit) is "reserve 0x03 Ontology domain (plug-and-play, zero rows)" — the exact opposite posture, and it is unchanged on current OGAR main:"Carries ZERO shared vocabulary rows... Do NOT mint rows here."The concept ids live in the producer crateogar-obo(Namespace::concept_id) by design.deepnsmhas noontology_vocabmodule and zero references anywhere in its source toogar_codebook,ConceptDomain, orconcepts_in_domain.The fix — smallest boundary
0x03XXblock to OGAR's actual, unchanged posture. No OGAR-side change needed or made — OGAR was never wrong.concepts_in_domain's doc, theCODEBOOKblock comment) and the one test asserting the hallucinated content (now assertsOntologyreturns empty likeOsint, withProjectMgmtas the populated-domain anti-vacuity check).lance-graph-ogar'sreserved_empty_domains_agree_across_the_mirrortest (referenced a nonexistent "0x0333 DisMech" mint — same class of stale claim; harmless to the assertion since it only checks domain-tag agreement, but misleading)."Run lance-graph-ogar fuse tests"→"...codebook-parity + hotplug-activation tests", and fix its comment (still referenced the compile-timeCOUNT_FUSE, retired 2026-08-14).A false alarm along the way, recorded so it isn't re-investigated
My local OGAR clone was frozen at PR #265 for most of this investigation. Against that stale tree,
ConceptDomain::{Weather, JavaRuntime, Analytics, BinaryLifting}appeared to not exist at all — a compile error that looked like a second, larger instance of the same hallucination pattern. After fast-forwarding toorigin/main(PR #281), all four are confirmed real: OGAR-side, operator-ruled, dated, with real merged PRs (#276/#277, 2026-08-18, the C-band reservation), and correctly mirrored inlance-graph-contract. False alarm — caught and verified before anything was written based on it.Verification
cargo test --manifest-path crates/lance-graph-contract/Cargo.toml --lib ogar_codebook: 15/15 green.lance-graph-ogarsuite against the now-synced OGAR sibling could not be re-run locally (this session's tmpfs filled mid-verification, and Bash access has not recovered) — this PR's own CI is the first full confirmation; please check thetestjob goes green before merging.Not touched
.claude/board/EPIPHANIES.md— it exceeds the 1MB GitHub API single-file fetch limit and this session's git/Bash access is down, so a safe byte-exact prepend isn't currently possible. This deliberately skips the repo's same-commit board-hygiene rule once rather than risk corrupting an append-only governance file with reconstructed content. A follow-up should add the entry once tooling recovers.Why this matters for #997 / #998
Both are example-only PRs (
sudoku_cognitive_corpus_probe.rs,probe_metacognitive_triangle.rs) whosetestCI job fails purely because they inherited this brokenmainvia their base SHA — confirmed viaget_check_runson both. Merging this should turn both green on rebase/retry without any change to either PR's own content.Generated by Claude Code