Repository navigation
Publish sync activity from the CLI so every UI shows syncs however they were started - #4956
Merged
Merged
Conversation
…o no client can stop or change it mid-write Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ges made elsewhere Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ey were started Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nect contract test Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e failed-import-status check Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Base automatically changed from
claude/site-control-sync-disable-32047f
to
trunk
October 1, 2026 05:10
…via-cli # Conflicts: # apps/cli/commands/pull.ts # apps/cli/commands/tests/pull.test.ts # apps/local/src/index.ts
… once and a lost one still settles Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
youknowriad
marked this pull request as ready for review
October 1, 2026 06:04
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
📊 Performance Test ResultsComparing 8305bdb vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…or syncs this window started Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Claude Code (Opus 5.5) designed and implemented this with me. It traced why the two push implementations diverged (git history) and wrote the tests. It also verified the full pipeline with the built CLI in an isolated config: a
studio pullrun from a terminal, using a deliberately invalid token, showed up live in the browser UI. I reviewed the design and the diff.Proposed Changes
push,pull,preview create/update) now publish their activity as events: pending, phase and progress, then success, error or cancelled. The UI's sync indicator, toasts and data refreshes are all driven by those events, so a sync looks the same whether a button, the agent or a terminal started it.pushSite) built from the same pieces as CLIpush. It existed because CLIpushhad no structured output. Since then, selective sync, cancel and waiting for the remote import were each added to one copy only. The button now runsstudio push, just as pull already ranstudio pull.pushgains--include-only, structured phases, the classified remote-import error messages, and--suppress-tracks-event.pushSite, the per-sync progress channels (IPC and SSE), and the connectors' progress callbacks are all gone.Testing Instructions
npm test -- apps/cli/commands/tests apps/cli/lib/tests apps/ui/src/data packages/common/sites apps/local. They cover push phases, the classified failure, pull's reported result, cancel handling, and a sync the UI didn't start being shown and announced.studio ui:studio pull --path <site> --remote-site <id> --options allin a terminal. The open UI should follow it the same way.Pre-merge Checklist
🤖 Generated with Claude Code