Repository navigation
Update design docs for the CLI events hub and CLI-run sync - #4974
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Claude Code (Opus 5.5) found the statements #4954–#4956 made outdated and rewrote them. It checked each new claim against the code (event channels, listeners, socket path) and dropped one sentence that overstated things. I reviewed the diff.
Proposed Changes
Docs only. These design docs described how Studio and the CLI communicate as it was before the events hub and CLI-run sync landed, so they would send a reader (or an agent) in the wrong direction:
cli.md:_eventsas one listener relaying onlysnapshot-eventto Redux. It now covers every event type, each app's own event socket, how the desktop andstudio uirelay events, and how the agentic UI renders them, whoever started the sync.studio-apps-and-surfaces.md:tools/commonpath (nowpackages/common) and the local server's SSE channel list.analytics-tracks.md:push/pullwith--suppress-tracks-event, and the old note that "an agentic-UI push runs the CLIexportcommand, not CLIpush" is gone.The new design doc and the AGENTS.md links proposed in #4963 (phase 0) are left for a separate PR.
Testing Instructions
apps/cli/commands/_events.ts,apps/cli/lib/event-hub.ts,apps/local/src/index.ts,apps/studio/src/modules/cli/lib/cli-events-subscriber.tsandpackages/common/sites/sync.ts.Pre-merge Checklist
🤖 Generated with Claude Code