add ImageKey class

[Hanmac]

Closes #7771

still in work, but just commited this state

[Jetz72]

What's the idea behind the List<String> of variations of the filepath?

The ImageType and ArtStyle enums might be simple enough and narrow enough in purpose to be nested within the ImageKey class, unless you plan to add more functionality to them later.

[Hanmac]

What's the idea behind the List<String> of variations of the filepath?

forge/forge-core/src/main/java/forge/ImageKeys.java

Lines 157 to 180 in 7e6f772

	if (dir.equals(CACHE_TOKEN_PICS_DIR)) {
	String setlessFilename = tempdata[0];
	String setCode = tempdata.length > 1 ? tempdata[1] : "";
	String collectorNumber = tempdata.length > 2 ? tempdata[2] : "";
	if (!setCode.isEmpty()) {
	if (!collectorNumber.isEmpty()) {
	file = findFile(dir, setCode + "/" + collectorNumber + "_" + setlessFilename);
	if (file != null) {
	cachedCards.put(filename, file);
	return file;
	}
	}
	file = findFile(dir, setCode + "/" + setlessFilename);
	if (file != null) {
	cachedCards.put(filename, file);
	return file;
	}
	}
	file = findFile(dir, setlessFilename);
	if (file != null) {
	cachedCards.put(filename, file);
	return file;
	}
	}

The plan is to use the variations for ImageKeys::getImageFile, and then call it in a loop:

for (String s : paths) {
    file = findFile(dir, s);
    if (file != null) {
        cachedCards.put(filename, file);
        return file;
    }
}

Also, the first path returned from the List should be used for the Downloader too

[Hanmac]

The ImageType and ArtStyle enums might be simple enough and narrow enough in purpose to be nested within the ImageKey class, unless you plan to add more functionality to them later.

i want to add these too:

forge/forge-core/src/main/java/forge/ImageKeys.java

Lines 16 to 22 in 7e6f772

	public static final String ICON_PREFIX = "i:";
	public static final String BOOSTER_PREFIX = "b:";
	public static final String FATPACK_PREFIX = "f:";
	public static final String BOOSTERBOX_PREFIX = "x:";
	public static final String PRECON_PREFIX = "p:";
	public static final String TOURNAMENTPACK_PREFIX = "o:";
	public static final String ADVENTURECARD_PREFIX = "a:";

but i don't know the FileStructure for them yet, nor can these be downloaded from Scryfall (yet)
i want to mail Scryfall to add Booster Images

[Jetz72]

The plan is to use the variations for ImageKeys::getImageFile, and then call it in a loop:
...
Also, the first path returned from the List should be used for the Downloader too

What's all that support for no-set and no-collector-number tokens used for? The Scryfall URL method won't work without those fields, so can anything new be downloaded to those paths?

[Hanmac]

The plan is to use the variations for ImageKeys::getImageFile, and then call it in a loop:
...
Also, the first path returned from the List should be used for the Downloader too

What's all that support for no-set and no-collector-number tokens used for? The Scryfall URL method won't work without those fields, so can anything new be downloaded to those paths?

It's not just for download, it's for finding images too, like Custom Sets

[github-actions]

This PR has not been updated in a while nad has been marked on stale. Stale PRs will be auto closed

[Hanmac]

@Eradev I need to add your new ⚡ Logic to the Download abilities of this class