Skip to content

Fix Meld art download (#7858) - #7884

Merged
Hanmac merged 4 commits into
Card-Forge:masterfrom
CTimmerman:Fix-Meld-art-download-(#7858)
Jun 25, 2025
Merged

Fix Meld art download (#7858)#7884
Hanmac merged 4 commits into
Card-Forge:masterfrom
CTimmerman:Fix-Meld-art-download-(#7858)

Conversation

@CTimmerman

Copy link
Copy Markdown
Contributor

Closes #7858.

@tool4ever

Copy link
Copy Markdown
Contributor

shouldn't this replace your older logic?

@CTimmerman

Copy link
Copy Markdown
Contributor Author

shouldn't this replace your older logic?

It does. Note the else and commit parent.

@tool4ever

tool4ever commented Jun 21, 2025

Copy link
Copy Markdown
Contributor

I look at the code and see it doesn't...

if (cp.getRules().getSplitType() == CardSplitType.Meld) {
cardCollectorNumber += face.equals("back") ? "b" : "a";
}

Comment thread forge-core/src/main/java/forge/util/ImageUtil.java
Comment thread forge-core/src/main/java/forge/util/ImageUtil.java Outdated

@Hanmac Hanmac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old part needs to be removed

@CTimmerman
CTimmerman marked this pull request as draft June 22, 2025 01:38
@CTimmerman
CTimmerman marked this pull request as ready for review June 22, 2025 09:39
@Hanmac
Hanmac requested review from Agetian and tool4ever June 22, 2025 16:49
@Agetian

Agetian commented Jun 25, 2025

Copy link
Copy Markdown
Contributor

Looks good to me, not sure about the collector number (comment above), but this works :)

@Hanmac

Hanmac commented Jun 25, 2025

Copy link
Copy Markdown
Contributor

@Agetian

Looks good to me, not sure about the collector number (comment above), but this works :)

the Collector Number Fix is something i need to look into later with my #7846 fixes

@Hanmac
Hanmac merged commit c207e74 into Card-Forge:master Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Mightstone and Weakstone art won't load

4 participants