Skip to content

Glasgow | 26-SDC-Mar | Mohammed Abdoon | Sprint 2 | Implement Linked list - #218

Open
M-Abdoon wants to merge 1 commit into
CodeYourFuture:mainfrom
M-Abdoon:sprint2/implement_linked_list
Open

Glasgow | 26-SDC-Mar | Mohammed Abdoon | Sprint 2 | Implement Linked list#218
M-Abdoon wants to merge 1 commit into
CodeYourFuture:mainfrom
M-Abdoon:sprint2/implement_linked_list

Conversation

@M-Abdoon

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

@github-actions

This comment has been minimized.

@M-Abdoon M-Abdoon added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Complexity The name of the module. labels Jul 15, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 15, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@M-Abdoon
M-Abdoon force-pushed the sprint2/implement_linked_list branch from ab148f1 to a84304c Compare July 15, 2026 12:36
@M-Abdoon M-Abdoon added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 15, 2026
@M-Abdoon M-Abdoon changed the title Glasgow | 26-SDC-Mar | Mohammed Abdoon| Sprint 2 | Implement Linked list Glasgow | 26-SDC-Mar | Mohammed Abdoon | Sprint 2 | Implement Linked list Jul 16, 2026
Comment on lines +31 to +38
if node.previous is None:
self.head = None
self.tail = None
else:
self.tail = node.previous
self.tail.next = None
node.previous = None
node.next = None

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just call remove()?

@@ -0,0 +1,53 @@
class Node:
__slots__ = ('value', 'next', 'previous')

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to use __slots__.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 17, 2026
@cjyuan

cjyuan commented Jul 17, 2026

Copy link
Copy Markdown

No "Changelist" section in the PR description?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Complexity The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants