Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions Sprint-2/implement_linked_list/linked_list.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
class Node:
__slots__ = ('value', 'next', 'previous')

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to use __slots__.


def __init__(self, value):
self.value = value
self.next = None
self.previous = None


class LinkedList:
def __init__(self):
self.head = None
self.tail = None

def push_head(self, value):
node = Node(value)
if self.head is None:
self.head = node
self.tail = node
else:
node.next = self.head
self.head.previous = node
self.head = node
return node

def pop_tail(self):
if self.tail is None:
raise IndexError('pop from empty list')
node = self.tail
value = node.value
if node.previous is None:
self.head = None
self.tail = None
else:
self.tail = node.previous
self.tail.next = None
node.previous = None
node.next = None
Comment on lines +31 to +38

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just call remove()?

return value

def remove(self, node):
if node.previous is not None:
node.previous.next = node.next
else:
self.head = node.next

if node.next is not None:
node.next.previous = node.previous
else:
self.tail = node.previous

node.next = None
node.previous = None
Loading