Skip to content

[review-stack 2/4] tests-removed — synap5e/feat/asset-record-content-split - #15916

Draft
synap5e wants to merge 1 commit into
synap5e/rs/asset-record-content-split/1-codefrom
synap5e/rs/asset-record-content-split/2-tests-removed
Draft

[review-stack 2/4] tests-removed — synap5e/feat/asset-record-content-split#15916
synap5e wants to merge 1 commit into
synap5e/rs/asset-record-content-split/1-codefrom
synap5e/rs/asset-record-content-split/2-tests-removed

Conversation

@synap5e

@synap5e synap5e commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Layer 2/4 of the review-and-land stack for synap5e/feat/asset-record-content-split, generated by
review-stack.py. Full collapse procedure: ~/adocs/review-stack.md. Once the
stack starts collapsing, don't rerun build/push on it
— a rebuild resets every
layer to its original scope from the untouched source branch and discards the collapse.

Once approved, merge this into #15915 (ordinary "Merge" — fast-forward). Once everything above has merged down into this one and it's approved, continue the collapse toward layer 1.

Rule: test file deleted, or modified with deleted/(added+deleted) >= 0.9
Question for this layer: For each dropped assertion: obsolete by a ruling, or covered by a tests-new test?
Source tip: 0b28b50ff278

Stack:

  1. [review-stack 1/4] code — synap5e/feat/asset-record-content-split #15915 code — Is the logic change right?
  2. [review-stack 2/4] tests-removed — synap5e/feat/asset-record-content-split #15916 tests-removed — For each dropped assertion: obsolete by a ruling, or covered by a tests-new test?
  3. [review-stack 3/4] tests-changed — synap5e/feat/asset-record-content-split #15917 tests-changed — Did the edits weaken an existing check?
  4. [review-stack 4/4] tests-new — synap5e/feat/asset-record-content-split #15918 tests-new — Is the code layer well covered?

Files (24, +253/-8228):

+/- path
M +12/-179 tests-unit/assets_test/queries/test_asset.py
M +17/-568 tests-unit/assets_test/queries/test_asset_info.py
M +20/-520 tests-unit/assets_test/queries/test_cache_state.py
M +10/-226 tests-unit/assets_test/queries/test_metadata.py
M +14/-360 tests-unit/assets_test/queries/test_tags.py
M +8/-304 tests-unit/assets_test/services/test_asset_management.py
M +12/-313 tests-unit/assets_test/services/test_bulk_ingest.py
M +10/-208 tests-unit/assets_test/services/test_enrich.py
M +16/-561 tests-unit/assets_test/services/test_ingest.py
M +10/-116 tests-unit/assets_test/services/test_tag_histogram.py
M +4/-349 tests-unit/assets_test/test_assets_missing_sync.py
M +30/-360 tests-unit/assets_test/test_crud.py
M +4/-200 tests-unit/assets_test/test_downloads.py
M +7/-117 tests-unit/assets_test/test_file_utils.py
M +5/-347 tests-unit/assets_test/test_list_cursor.py
M +5/-393 tests-unit/assets_test/test_metadata_filters.py
M +4/-214 tests-unit/assets_test/test_preview_url.py
M +3/-68 tests-unit/assets_test/test_prompt_id_enforcement.py
M +3/-142 tests-unit/assets_test/test_prune_orphaned_assets.py
M +4/-481 tests-unit/assets_test/test_sync_references.py
M +16/-254 tests-unit/assets_test/test_tags_api.py
M +4/-177 tests-unit/assets_test/test_temp_assets.py
M +11/-664 tests-unit/assets_test/test_uploads.py
M +24/-1107 tests-unit/seeder_test/test_seeder.py

@synap5e
synap5e force-pushed the synap5e/rs/asset-record-content-split/1-code branch from 763c440 to 0bf9e87 Compare August 27, 2026 03:33
@synap5e
synap5e force-pushed the synap5e/rs/asset-record-content-split/2-tests-removed branch from 249d65a to 6c02978 Compare August 27, 2026 03:33
@synap5e
synap5e force-pushed the synap5e/rs/asset-record-content-split/1-code branch from 0bf9e87 to 85c1b86 Compare August 27, 2026 20:10
@synap5e
synap5e force-pushed the synap5e/rs/asset-record-content-split/2-tests-removed branch from 6c02978 to 526366b Compare August 27, 2026 20:10
@synap5e
synap5e force-pushed the synap5e/rs/asset-record-content-split/1-code branch from 85c1b86 to d002d4a Compare August 28, 2026 02:30
@synap5e
synap5e force-pushed the synap5e/rs/asset-record-content-split/2-tests-removed branch from 526366b to 2946045 Compare August 28, 2026 02:30
Review-and-land stack for synap5e/feat/asset-record-content-split, generated by review-stack.py. Once approved,
merges DOWN into the layer below (a fast-forward); only the bottom layer
squash-merges into the real base. See ~/adocs/review-stack.md.
Rule: test file deleted, or modified with deleted/(added+deleted) >= 0.9
Question: For each dropped assertion: obsolete by a ruling, or covered by a tests-new test?
Source tip: 0b28b50
Merge-base: 783545f
@synap5e
synap5e force-pushed the synap5e/rs/asset-record-content-split/1-code branch from d002d4a to 4a76cb4 Compare August 28, 2026 04:04
@synap5e
synap5e force-pushed the synap5e/rs/asset-record-content-split/2-tests-removed branch from 2946045 to 2a65f7e Compare August 28, 2026 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant