Skip to content

[review-stack 3/4] tests-changed — synap5e/feat/asset-record-content-split - #15917

Draft
synap5e wants to merge 1 commit into
synap5e/rs/asset-record-content-split/2-tests-removedfrom
synap5e/rs/asset-record-content-split/3-tests-changed
Draft

[review-stack 3/4] tests-changed — synap5e/feat/asset-record-content-split#15917
synap5e wants to merge 1 commit into
synap5e/rs/asset-record-content-split/2-tests-removedfrom
synap5e/rs/asset-record-content-split/3-tests-changed

Conversation

@synap5e

@synap5e synap5e commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Layer 3/4 of the review-and-land stack for synap5e/feat/asset-record-content-split, generated by
review-stack.py. Full collapse procedure: ~/adocs/review-stack.md. Once the
stack starts collapsing, don't rerun build/push on it
— a rebuild resets every
layer to its original scope from the untouched source branch and discards the collapse.

Once approved, merge this into #15916 (ordinary "Merge" — fast-forward). Once everything above has merged down into this one and it's approved, continue the collapse toward layer 1.

Rule: remaining modified test files (incl. conftest.py / helpers)
Question for this layer: Did the edits weaken an existing check?
Source tip: 0b28b50ff278

Stack:

  1. [review-stack 1/4] code — synap5e/feat/asset-record-content-split #15915 code — Is the logic change right?
  2. [review-stack 2/4] tests-removed — synap5e/feat/asset-record-content-split #15916 tests-removed — For each dropped assertion: obsolete by a ruling, or covered by a tests-new test?
  3. [review-stack 3/4] tests-changed — synap5e/feat/asset-record-content-split #15917 tests-changed — Did the edits weaken an existing check?
  4. [review-stack 4/4] tests-new — synap5e/feat/asset-record-content-split #15918 tests-new — Is the code layer well covered?

Files (13, +1046/-1217):

+/- path
M +34/-8 tests-unit/assets_test/conftest.py
M +121/-1 tests-unit/assets_test/helpers.py
M +12/-0 tests-unit/assets_test/queries/conftest.py
M +24/-103 tests-unit/assets_test/queries/test_asset_reference_keyset.py
M +13/-4 tests-unit/assets_test/services/conftest.py
M +26/-0 tests-unit/assets_test/services/test_asset_response_loader_path.py
M +87/-2 tests-unit/assets_test/services/test_asset_response_preview_url.py
M +37/-182 tests-unit/assets_test/services/test_tagging.py
M +301/-725 tests-unit/assets_test/test_list_filter.py
M +320/-190 tests-unit/execution_test/test_enrich_output.py
M +3/-1 tests-unit/folder_paths_test/filter_by_content_types_test.py
M +1/-1 tests-unit/security_test/test_ghsa_779p_06_inline_svg_image_dest.py
M +67/-0 tests/execution/testing_nodes/testing-pack/specific_tests.py

@synap5e
synap5e force-pushed the synap5e/rs/asset-record-content-split/2-tests-removed branch from 249d65a to 6c02978 Compare August 27, 2026 03:33
@synap5e
synap5e force-pushed the synap5e/rs/asset-record-content-split/3-tests-changed branch from d9eff01 to 196911a Compare August 27, 2026 03:33
@synap5e
synap5e force-pushed the synap5e/rs/asset-record-content-split/2-tests-removed branch from 6c02978 to 526366b Compare August 27, 2026 20:10
@synap5e
synap5e force-pushed the synap5e/rs/asset-record-content-split/3-tests-changed branch from 196911a to be8d90f Compare August 27, 2026 20:10
@synap5e
synap5e force-pushed the synap5e/rs/asset-record-content-split/2-tests-removed branch from 526366b to 2946045 Compare August 28, 2026 02:30
@synap5e
synap5e force-pushed the synap5e/rs/asset-record-content-split/3-tests-changed branch from be8d90f to ec28834 Compare August 28, 2026 02:30
Review-and-land stack for synap5e/feat/asset-record-content-split, generated by review-stack.py. Once approved,
merges DOWN into the layer below (a fast-forward); only the bottom layer
squash-merges into the real base. See ~/adocs/review-stack.md.
Rule: remaining modified test files (incl. conftest.py / helpers)
Question: Did the edits weaken an existing check?
Source tip: 0b28b50
Merge-base: 783545f
@synap5e
synap5e force-pushed the synap5e/rs/asset-record-content-split/2-tests-removed branch from 2946045 to 2a65f7e Compare August 28, 2026 04:04
@synap5e
synap5e force-pushed the synap5e/rs/asset-record-content-split/3-tests-changed branch from ec28834 to 91d4bf3 Compare August 28, 2026 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant