Skip to content

Game titles seem to be quoted needlessly #282

Description

@Wesmania

The lobby connection uses cgi.escape to escape game titles. From what I can tell the server does not need this encoding for anything, as it doesn't use the "title" field other than receive it and send it. The client always receives a game as a "game_info" command - apart from passing it around and sending it back, it prints it in a couple of places where it uses HTML escaping (tooltips, game widgets), and places where it doesn't (live replay tabs). This causes escape sequences to print in a couple places.

Escaping the game title seems needless, and there are places where we would need to unescape it in the client. We should fix the client and start sending the title unquoted.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions