Issue/#282 Game titles seem to be quoted needlessly - #625
Merged
Askaholic merged 1 commit intoJul 12, 2020
Merged
Conversation
Contributor
Author
|
No i didn't, will try to do some more test. Ideally these tests belong to the client code ofcourse, we don't trust the client, and the client shouldn't trust us. :-) Did the tests you proposed and they showed correctly. |
micheljung
approved these changes
Jul 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hej, i created a bunch of games using some silly tool i made and made sure they were correct in the client. All seems ok. I could not find any places where the & i mean & would pop up though. Nice to see that html injection works in this box.
Checked the client (a little bit) for any unescape code, but java isn't really my cup of tea.
Fixes #282