Skip to content

Issue/#282 Game titles seem to be quoted needlessly - #625

Merged
Askaholic merged 1 commit into
FAForever:developfrom
MartijnPieterse:issue/#282-Game-titles-seem-to-be-quoted-needlessly
Jul 12, 2020
Merged

Issue/#282 Game titles seem to be quoted needlessly#625
Askaholic merged 1 commit into
FAForever:developfrom
MartijnPieterse:issue/#282-Game-titles-seem-to-be-quoted-needlessly

Conversation

@MartijnPieterse

@MartijnPieterse MartijnPieterse commented Jul 9, 2020

Copy link
Copy Markdown
Contributor

Hej, i created a bunch of games using some silly tool i made and made sure they were correct in the client. All seems ok. I could not find any places where the & i mean & would pop up though. Nice to see that html injection works in this box.

Checked the client (a little bit) for any unescape code, but java isn't really my cup of tea.

Fixes #282

@Askaholic Askaholic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. I requested some of the Java guys to take a look. Did you try stuff like <b>Some text</b> or <p style="color:red">Some text</p>?

Also can you add "Fixes #282" to the PR description please?

@MartijnPieterse

MartijnPieterse commented Jul 10, 2020

Copy link
Copy Markdown
Contributor Author

No i didn't, will try to do some more test. Ideally these tests belong to the client code ofcourse, we don't trust the client, and the client shouldn't trust us. :-)

Did the tests you proposed and they showed correctly.
Some logging:

TRACE    Jul 11  09:09:07 LobbyConnection                >> test: {'command': 'game_launch', 'args': ['/numgames', 5], 'uid': 41946, 'mod': 'faf', 'name': '<p style="color:red">Some text</p>', 'init_mode': 0}
TRACE    Jul 11  09:09:07 ServerContext                  ]]: {'command': 'game_info', 'visibility': 'public', 'password_protected': False, 'uid': 41946, 'title': '<p style="color:red">Some text</p>', 'state': 'open', 'featured_mod': 'faf', 'sim_mods': {}, 'mapname': 'the_crucible.v0002', 'map_file_path': 'maps/the_crucible.v0002.zip', 'host': 'test', 'num_players': 0, 'max_players': 12, 'launched_at': None, 'teams': {}}

@Askaholic
Askaholic merged commit 91a853f into FAForever:develop Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Game titles seem to be quoted needlessly

3 participants