Fix wood recipe - #523
Conversation
…others) not being done for 1.20 yet
…, haven't yet tried to build/launch at all
…ls are gone, so block properties seem to be mostly made by copying from other blocks and changing relevant things. Data generation seems to have changed, and recipes need a recipe category.
…hich blocks can be removed by OpDestroyFluid.
…ore rendering fixes
…and fix some other datagen stuff.
…rge, committing this so I don't lose it in case I want to come back to it
Implement arch-ex integration
pulling in more bug fixes, Falkory's new textures, and Cypher's EnvironmentExtensions
|
hey, thanks for the PR! unfortunately this file is in |
|
I totally forgot about this pr and yeah I see I missed that, I can amend the pr to change the generator instead. |
|
I can't load this project locally because of various gradle issues so I didn't have IntelliSense and couldn't run the data-gen to check but it should be correct 😅 |
|
looks good to me too, although we should probably run it just to make sure it works first. I think the edified wood variants should exist ? but don't currently. It looks like we don't have models for them either. Should be easy enough to add them in though, don't know if we want to do that as a part of this PR or separate, @object-Object ? |
|
@SamsTheNerd depends how much effort it takes / how big of a change it would be - I see EDIFIED_WOOD in a lot of places but i'm not sure if you'd need all those for the variants? |
|
I can't get this repo setup locally, so it would be best if someone else did that if it were done at all. |
|
(side note: i feel like the ideal solution would just be to do all of the edified wood variant stuff in one loop and/or based on one data source somewhere (an enum?), so we don't keep forgetting to add blocks for the variants, but idk how doable that is.) |
|
ok - I'll run it locally, then assuming it works we can merge this and figure out the variants later. |
|
Right... the reason you can't get it working locally is probably because the build is still broken on main. I'd also rather not merge into main right now since it'll probably make resolving the 1.20 merge conflicts even more of a hassle. @Bawnorton would you be able to rebase your PR onto the |
… into patch-wood-recipe
|
rebased... probably better to just close this and start a new pr onto the 1.20 branch tbh lol |
|
uh, yeah probably... that was not exactly the type of rebase i was talking about hah (for posterity, the original rebase command should have been this: |
|
Yeah, my bad... I just realized I rebased the wrong way... git is hard sometimes 😅 |
I don't believe this recipe is intentional