Skip to content

Fix wood recipe data generator - #542

Merged
object-Object merged 2 commits into
FallingColors:1.20from
Bawnorton:patch-wood-recipe-datagen
Nov 26, 2023
Merged

Fix wood recipe data generator#542
object-Object merged 2 commits into
FallingColors:1.20from
Bawnorton:patch-wood-recipe-datagen

Conversation

@Bawnorton

Copy link
Copy Markdown
Contributor

Continuation of #523 targeting the 1.20 branch

@Bawnorton Bawnorton changed the title Fix wood data generator Fix wood recipe data generator Nov 17, 2023

@SamsTheNerd SamsTheNerd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like it assigns the stripped log -> stripped wood recipe twice ? once in the map loop and then once below it.

      for (var entry : EDIFIED_LOG_TO_WOOD.entrySet()) {
            var log = entry.getKey();
            var wood = entry.getValue();
            ShapedRecipeBuilder.shaped(RecipeCategory.BUILDING_BLOCKS, wood, 3)
                    .define('W', log)
                    .pattern("WW")
                    .pattern("WW")
                    .unlockedBy("has_item", hasItem(log)).save(recipes);
        }

        ShapedRecipeBuilder.shaped(RecipeCategory.BUILDING_BLOCKS, HexBlocks.STRIPPED_EDIFIED_WOOD, 3)
            .define('W', HexBlocks.STRIPPED_EDIFIED_LOG)
            .pattern("WW")
            .pattern("WW")
            .unlockedBy("has_item", hasItem(HexBlocks.STRIPPED_EDIFIED_LOG)).save(recipes);

also yay no .DS_Store :D

otherwise looks fine to me, as long as everything runs fine, which as far as I can tell it should ?

@object-Object
object-Object merged commit 50f0643 into FallingColors:1.20 Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants