Skip to content

Replace collate_data with hexdoc - #525

Closed
object-Object wants to merge 408 commits into
FallingColors:1.20from
object-Object:docgen-2-1.20
Closed

Replace collate_data with hexdoc#525
object-Object wants to merge 408 commits into
FallingColors:1.20from
object-Object:docgen-2-1.20

Conversation

@object-Object

@object-Object object-Object commented Sep 11, 2023

Copy link
Copy Markdown
Member

This is by no means ready to be merged yet, but it's getting close-ish, and this is a convenient place to track what's left to do.

Also - datagen hasn't been run on the upstream branch, so the diff looks bigger than it really is.

Planned features/changes

  • Redo the hexdoc and hexdoc_merge commands to use Typer instead of argparse
  • Remove base_asset_urls
  • Publish the CI actions/workflow somewhere
  • Re-add some sort of end-to-end testing (probably not snapshots since the book is much more in flux now, but something)
  • Test case for mock addon book
  • Fix mobile styling for navbar dropdowns (or find a nice web developer to do it for me :) )
  • PR to hexdummy
  • Fix Miscellaneous docs issues #391

Known issues

  • Clicking book name in Discord embed with anchor goes to the top of the book instead of the specific anchor

Temporary stuff to undo

Includes changes from #509.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants