Better Circle Scanning - #910
Merged
Merged
Conversation
…`ServerChunkCache#getChunkFuture`
Closed
object-Object
force-pushed
the
main
branch
4 times, most recently
from
November 22, 2025 22:04
107cf95 to
7202ed7
Compare
s5bug
reviewed
May 10, 2026
| } | ||
| val future = level.chunkSource.getChunkFuture(chunk.x,chunk.z, ChunkStatus.EMPTY,true).get() | ||
| if (future.left().isPresent){ | ||
| chunks.put(chunkLong, future.left().get() as ImposterProtoChunk) |
Contributor
Author
There was a problem hiding this comment.
Oh woops, I don't believe it is; thank you for the catch! I'll make ChunkScanning hold a list of ChunkAccesss instead
…ing.kt Co-authored-by: Aly Cerruti <aprime2003@gmail.com>
Improved Comment and removed unused import
Robotgiggle
approved these changes
Aug 11, 2026
Robotgiggle
left a comment
Member
There was a problem hiding this comment.
LGTM! Can confirm this significantly improves performance of high density circle spam, even when connected to enormous ambit rods.
object-Object
added a commit
that referenced
this pull request
Aug 16, 2026
## Do not squash!!! Includes PRs: - #1224 - #1199 - #1103 - #1235 - #1236 - #1242 - #910 - #1248 - #1252 - #1251 - #1261 --------- Co-authored-by: IridescentVoid <265486018+IridescentVoid@users.noreply.github.com> Co-authored-by: Robotgiggle <88736742+Robotgiggle@users.noreply.github.com> Co-authored-by: Stickia <93604201+Stick404@users.noreply.github.com> Co-authored-by: Hexxy Weblate <weblate@hexxy.media> Co-authored-by: [object Object] <object@objectobject.ca> Co-authored-by: Florian Meyer <flommeyer@gmail.com> Co-authored-by: ChuijkYahus <zhaoclleonard23@outlook.com> Co-authored-by: Anonymous <noreply@weblate.org> Co-authored-by: miyucomics <72044529+miyucomics@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves Spell Circle scanning by making a custom system to use
ServerChunkCache#getChunkFuture's quicker chunk loading.Creates a Helper Class in case spells/addons wish to use this system