fix(rp2040): encode complete firmware at XIP address#1046
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe PR documents FastLED/boards as the authoritative USB VID/PID source and revises fixture refresh guidance. It also changes RP2040 UF2 full-image encoding to use the XIP address base and adds coverage for boot2-prefixed firmware. ChangesUSB VID/PID source documentation
RP2040 UF2 full-image encoding
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct the RP2040 UF2 base for fbuild's complete firmware.bin. The image includes boot2 at 0x10000000; 0x2000 is only valid for app-only BINs. Add a boot2-prefix regression test and document the FastLED/boards-only VID/PID policy. Closes the incorrect-address portion of #1040; do not claim hardware acceptance until a real 2E8A:000A CDC endpoint is observed.
Summary by CodeRabbit
Bug Fixes
Documentation