feat(rp2040): support RAM-only UF2 loads#1072
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughRP2040 deployment now validates UF2 images as flash or RAM targets. RAM images produce a ChangesRP2040 RAM deployment
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant DeployMethod
participant prepare_uf2_artifact
participant validate_uf2
participant CDC_Runtime
DeployMethod->>prepare_uf2_artifact: prepare UF2 artifact
prepare_uf2_artifact->>validate_uf2: validate and classify UF2
validate_uf2-->>prepare_uf2_artifact: Uf2Target::Ram or Uf2Target::Flash
prepare_uf2_artifact-->>DeployMethod: artifact and target
DeployMethod->>DeployMethod: return RamLoad for RAM target
DeployMethod->>CDC_Runtime: discover or recover runtime port for flash target
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
30 tasks
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The attached Pico 1 already enters ROM USB, but every flash UF2 stalls on the first erase/program. Raspberry Pi's boot ROM supports RAM UF2 independently of QSPI, making it the decisive transport-vs-flash discriminator.
Validation
Supports #1049.
Summary by CodeRabbit
New Features
Bug Fixes