refactor(deploy): consume FastLED/boards USB profiles#1060
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughDeploy-port selection and LPC-Link2, Probe-RS, and Teensy discovery now use FastLED/boards USB profile metadata instead of fixed VID/PID heuristics. Board identifiers flow into deployment matching, DFU selectors are explicit, and related tests and audit documentation were updated. ChangesUSB profile matching migration
Possibly related issues
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the remaining deploy-consumer rows in #1047 and #1049.\n\n- automatic deploy-port selection uses board membership and typed runtime profiles instead of embedded vendor lists\n- missing profiles fail closed instead of choosing an unrelated COM port\n- RP2040/RP2350 generation selection uses runtime profile family metadata\n- Teensy CDC, NXP probe discovery, and LPC-Link2 factory-firmware detection use typed purpose/role/platform/family/generation metadata\n- dfu-util argv construction requires a caller-supplied registry selector\n- exact identities remain test-only fixtures\n\nDepends on FastLED/boards#52 for the split LPC-Link2 semantics.\n\nValidation:\n- fbuild-daemon deploy_port: 8 passed\n- fbuild-deploy: 169 passed, 8 hardware tests ignored\n- strict clippy for daemon/deploy passed\n- rustfmt and diff check passed\n- independent pre-push review: clean
Summary by CodeRabbit
Bug Fixes
Documentation