feat: ingest typed USB transport profiles#1053
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughAdds verified typed USB profile ingestion and caching, exposes profile and board lookups, initializes profiles in the daemon, and uses runtime profile data for RP2040/RP2350 CDC port discovery. ChangesTyped USB profile integration
Estimated code review effort: 4 (Complex) | ~60 minutes Possibly related issues
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a milestone for #1047 and the USB-identity phase of #1049. It intentionally does not close either issue; repo-wide literal migration and attached-board acceptance remain.
Validation
2e8a:0003ROM UF2 and2e8a:000aruntime CDC roles resolvedsoldr cargo test -p fbuild-core usb::profiles(5 passed, one live smoke ignored by default)soldr cargo test -p fbuild-deploy rp2040(13 passed)soldr cargo test -p fbuild-daemon(194 passed; expected hardware/process tests ignored)soldr cargo clippy -p fbuild-core -p fbuild-deploy -p fbuild-daemon --all-targets -- -D warningsgit diff --checkDepends on FastLED/boards#48, #49, #50, and #51 (all merged; public artifact verified).
Summary by CodeRabbit