Skip to content

fix(ch32v): validate framework selection#1114

Merged
zackees merged 1 commit into
mainfrom
fix/ch32v-framework-validation
Jul 21, 2026
Merged

fix(ch32v): validate framework selection#1114
zackees merged 1 commit into
mainfrom
fix/ch32v-framework-validation

Conversation

@zackees

@zackees zackees commented Jul 21, 2026

Copy link
Copy Markdown
Member

Closes #1108

Summary:

  • reject unsupported CH32V framework values with an actionable error
  • label the four existing Arduino builds as framework = arduino
  • advertise arduino on the two missing CH32V board definitions

Validation:

  • soldr rustfmt --check crates/fbuild-build-mcu/src/ch32v/orchestrator.rs
  • targeted soldr cargo test was attempted but the shared Windows toolchain did not return within the local validation window

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 33 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 715bfab7-9a45-4356-a487-cd9fde41286b

📥 Commits

Reviewing files that changed from the base of the PR and between c2747c9 and 96bf279.

📒 Files selected for processing (7)
  • crates/fbuild-build-mcu/src/ch32v/orchestrator.rs
  • crates/fbuild-config/assets/boards/json/genericCH32V208WBU6.json
  • crates/fbuild-config/assets/boards/json/genericCH32V303VCT6.json
  • tests/platform/ch32v103/platformio.ini
  • tests/platform/ch32v208/platformio.ini
  • tests/platform/ch32v303/platformio.ini
  • tests/platform/ch32x035/platformio.ini
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ch32v-framework-validation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

ch32v: framework field is ignored — noneos-sdk envs silently build the OpenWCH Arduino core (4 of 9 CI envs affected)

1 participant