Skip to content

fix(ch32v): main fails to compile - adjacent string literals in validate_ch32v_framework format! (#1114 regression) #1117

Description

@zackees

Severity: CRITICAL — main does not compile. Blocks every other bench fix.

Problem

validate_ch32v_framework in crates/fbuild-build-mcu/src/ch32v/orchestrator.rs:257-260 contains two adjacent string literals inside format!:

Some(other) => Err(fbuild_core::FbuildError::ConfigError(format!(
    "ch32v: framework = {other} is not supported yet; only `framework = arduino` "
        "builds today (FastLED/fbuild#1108)"
))),

Rust has no implicit adjacent-literal concatenation — this is a syntax error. Introduced by PR #1114 (commit df6901c).

Evidence (verified)

Fix

Merge into one literal (or use concat!). One line. Add the missing space handling: the current text ends the first fragment with a trailing space, so the joined message should read ...only \framework = arduino` builds today (#1108)`.

Acceptance

Found during the 2026-07-21 CH32V bench-readiness sweep.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status
    Triage

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions