Skip to content

fix(ch32v): clean up board data and dead linker code#1116

Merged
zackees merged 1 commit into
mainfrom
fix/ch32v-data-docs
Jul 21, 2026
Merged

fix(ch32v): clean up board data and dead linker code#1116
zackees merged 1 commit into
mainfrom
fix/ch32v-data-docs

Conversation

@zackees

@zackees zackees commented Jul 21, 2026

Copy link
Copy Markdown
Member

Closes #1109

Summary:

  • correct CH32X035 clock source metadata
  • remove unused CH32V variant linker-script discovery and tests
  • retain the intentional V208 variant reuse documented in the board data
  • confirm the CH32V-family badges/status are current on main

Validation:

  • soldr rustfmt --check crates/fbuild-library/src/library/ch32v_core.rs
  • zero CH32V references remain to get_linker_script/find_ld_file
  • datasheets stretch is a separate FastLED/datasheets repository task

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 29 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cab13a1e-1f48-4d57-ac71-c5dfb7cf39b1

📥 Commits

Reviewing files that changed from the base of the PR and between 9880ada and 61de5d3.

📒 Files selected for processing (2)
  • crates/fbuild-config/assets/boards/json/genericCH32X035C8T6.json
  • crates/fbuild-library/src/library/ch32v_core.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ch32v-data-docs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

ch32v: board-data and docs nits — X035 clock_source, V208 variant reuse, BOARD_STATUS drift, dead get_linker_script, missing WCH datasheets

1 participant